Skip to content
This repository has been archived by the owner on Apr 8, 2024. It is now read-only.

updated symptoms #457

Merged
merged 3 commits into from
Sep 16, 2021
Merged

updated symptoms #457

merged 3 commits into from
Sep 16, 2021

Conversation

SevKohler
Copy link
Contributor

No description provided.

@SevKohler
Copy link
Contributor Author

@wlad thats the random failing test, any idea how to fix this or at least make it disappear for now so i can merge ?
I tested the payload locally and it worked, so i guess its the bug you described here

@wlad
Copy link
Contributor

wlad commented Sep 9, 2021

@wlad thats the random failing test, any idea how to fix this or at least make it disappear for now so i can merge ?
I tested the payload locally and it worked, so i guess its the bug you described here

@SevKohler I don't think this is related.

@ppazos can you please check whether the test is still valid by lookig at below output from CI. Expected result is 201 but actual result is 422

{
    "request": {
        "method": "POST",
        "url": "http://localhost:8888/fhir-bridge/fhir/Condition",
        "scheme": "http",
        "netloc": "localhost:8888",
        "path": "/fhir-bridge/fhir/Condition",
        "query": {},
        "body": {
            "resourceType": "Condition",
            "id": "8cb12ab0-3563-4154-bfeb-25aa897c2105",
            "meta": {
                "profile": [
                    "https://www.netzwerk-universitaetsmedizin.de/fhir/StructureDefinition/symptoms-covid-19"
                ]
            },
            "modifierExtension": [
                {
                    "url": "https://www.netzwerk-universitaetsmedizin.de/fhir/StructureDefinition/uncertainty-of-presence",
                    "valueCodeableConcept": {
                        "coding": [
                            {
                                "code": "261665006",
                                "display": "Unknown (qualifier value)",
                                "system": "http://snomed.info/sct"
                            }
                        ],
                        "text": "Presence of symptom is unknown."
                    }
                }
            ],
            "category": [
                {
                    "coding": [
                        {
                            "code": "75325-1",
                            "display": "Symptom",
                            "system": "http://loinc.org"
                        }
                    ]
                }
            ],
            "code": {
                "coding": [
                    {
                        "code": "36955009",
                        "display": "Loss of taste",
                        "system": "http://snomed.info/sct"
                    }
                ]
            },
            "onsetDateTime": "2020-10-05",
            "recordedDate": "2020-10-05",
            "subject": {
                "identifier": {
                    "system": "urn:ietf:rfc:4122",
                    "value": "1ba652fb-4e80-4ddb-b073-530adc5f479a"
                }
            },
            "verificationStatus": {
                "coding": [
                    {
                        "code": "confirmed",
                        "display": "Confirmed",
                        "system": "http://terminology.hl7.org/CodeSystem/condition-ver-status"
                    },
                    {
                        "code": "410605003",
                        "display": "Confirmed present (qualifier value)",
                        "system": "http://snomed.info/sct"
                    }
                ]
            }
        },
        "headers": {
            "Accept": "application/json",
            "Content-Type": "application/json",
            "User-Agent": "RESTinstance/1.0.2",
            "Prefer": "return=representation",
            "Authorization": "Basic bXl1c2VyOm15UGFzc3dvcmQ0MzI="
        },
        "proxies": {},
        "timeout": [
            null,
            null
        ],
        "cert": null,
        "sslVerify": false,
        "allowRedirects": true,
        "timestamp": {
            "utc": "2021-09-09T11:34:55.088615+00:00",
            "local": "2021-09-09T11:34:55.088615+00:00"
        }
    },
    "response": {
        "seconds": 0.03632,
        "status": 422,
        "body": {
            "resourceType": "OperationOutcome",
            "issue": [
                {
                    "severity": "error",
                    "code": "processing",
                    "diagnostics": "unk-1: 'If verificationStatus is present, uncertaintyOfPresence-Extension SHALL NOT be present.' failed",
                    "location": [
                        "Condition",
                        "Line 1, Col 2"
                    ]
                }
            ]
        },
        "headers": {
            "Vary": "Origin, Access-Control-Request-Method, Access-Control-Request-Headers",
            "X-Powered-By": "HAPI FHIR 5.3.3 REST Server (FHIR Server; FHIR 4.0.1/R4)",
            "X-Request-ID": "kdnLW1JfxulyeYxp",
            "Content-Type": "application/fhir+json;charset=UTF-8",
            "Transfer-Encoding": "chunked",
            "Date": "Thu, 09 Sep 2021 11:34:54 GMT",
            "Keep-Alive": "timeout=60",
            "Connection": "keep-alive"
        }
    }
}

Due to the error "diagnostics": "unk-1: 'If verificationStatus is present, uncertaintyOfPresence-Extension SHALL NOT be present.' failed" I guess that the test isn't valid any more with the given payload. But is just my guess.

@sonarcloud
Copy link

sonarcloud bot commented Sep 15, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@SevKohler SevKohler merged commit c3f53ac into develop Sep 16, 2021
@SevKohler SevKohler deleted the update_symptom branch September 16, 2021 10:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants