Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite js files to ts and and useful types #65

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

eiabea
Copy link
Owner

@eiabea eiabea commented Oct 18, 2020

Started with cache controller and all the tests

Resolves #35

Started with cache controller and all the tests
@codecov
Copy link

codecov bot commented Oct 18, 2020

Codecov Report

Merging #65 into master will decrease coverage by 87.81%.
The diff coverage is 31.68%.

Impacted file tree graph

@@             Coverage Diff              @@
##            master      #65       +/-   ##
============================================
- Coverage   100.00%   12.18%   -87.82%     
============================================
  Files           12       13        +1     
  Lines          484      476        -8     
  Branches         0       18       +18     
============================================
- Hits           484       58      -426     
- Misses           0      418      +418     
Impacted Files Coverage Δ
app.ts 0.00% <0.00%> (ø)
controller/temp.controller.ts 14.28% <14.28%> (ø)
controller/cache.controller.ts 16.66% <16.66%> (ø)
controller/index.ts 100.00% <100.00%> (ø)
controller/slave.controller.ts 100.00% <100.00%> (ø)
routes/v1/status.route.js 0.00% <0.00%> (-100.00%) ⬇️
controller/heat.controller.js 0.00% <0.00%> (-100.00%) ⬇️
controller/relay.controller.js 0.00% <0.00%> (-100.00%) ⬇️
controller/schedule.controller.js 0.00% <0.00%> (-100.00%) ⬇️
controller/calendar/nextcloud.js 9.25% <0.00%> (-90.75%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45fded1...47f53c0. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reimplement in TypeScript
1 participant