-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inner mpgd barrel geo update #732
Conversation
…-facing frames. Worsened resolution of readout.
…ivial type through variadic function".
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…is, independently for inner/outer sectors via "MultiSegmentation".
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Plots showing the distributions of:
Setup =
|
FYI, https://eicweb.phy.anl.gov/containers/eic_container/-/merge_requests/963 for inclusion of AIDASoft/DD4hep#1294. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Thanks! I added some comments. I will wait to approve until later this when the pipelines should be able to run.
Updated branch to restart CI pipelines with updated DD4hep installation. |
MPGDCylinderBarrelTracker_geo.cpp": Remove unneeded cast. Co-authored-by: Wouter Deconinck <[email protected]>
Cosmetics... Co-authored-by: Wouter Deconinck <[email protected]>
Cast DD4hep units in printout. Co-authored-by: Wouter Deconinck <[email protected]>
Restricting scope of ROOT namespace. Co-authored-by: Wouter Deconinck <[email protected]>
…o inner-mpgd-barrel-geoUpdate
This, to obtain a resolution of about 2cm, i.e. approx., the sum of two neighbouring frames.
Hello,
Does this mean that it's connected w/ the specification of the sensitive surface? or the <layer_material/> which I modified lately? |
I noticed the failing reconstruction_benchmarks check yesterday and looked into it. The issue is in legacy code, and stems from an incomplete list of supported surfaces in our export to a 3D graphics file for visualization and debugging. We have fixed the equivalent code in our up-to-date code, and yesterday I propagated a fix to the legacy code as well. It takes a day or so for this to propagate to the containers in which we run the checks, so I suspect this will be resolved by Monday at the latest. |
Hello, |
I re-triggered the job and it now succeeded. All checks now pass. |
Briefly, what does this PR introduce?
Update the MPGD inner barrel, making it a set of cylindrical, as opposed to flat, tiles.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
Yes. Users need to update their DD4hep private repository to revision #c3b305ce of the AIDASoft/DD4hep github, see "AIDASoft/DD4hep@c3b305ce".
Does this PR change default behavior?
Yes.