Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): split linux-eic-shell into reusable workflows #778

Merged
merged 4 commits into from
Sep 18, 2024

Conversation

wdconinc
Copy link
Contributor

Briefly, what does this PR introduce?

This PR splits linux-eic-shell into more managable chunks by using local reusable workflows.

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue: linux-eic-shell.yml is a mess)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No.

Does this PR change default behavior?

No.

@github-actions github-actions bot added the topic: infrastructure Regarding build system, CI, CD label Sep 10, 2024
@wdconinc wdconinc marked this pull request as ready for review September 10, 2024 20:30
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wdconinc
Copy link
Contributor Author

@veprbl
Copy link
Member

veprbl commented Sep 11, 2024

It it's nightly it might be failing without the eic/detector_benchmarks#50, otherwise it should work.

@wdconinc
Copy link
Contributor Author

It it's nightly it might be failing without the eic/detector_benchmarks#50, otherwise it should work.

You're telling me to force merge, right? ;-)

@wdconinc wdconinc added this pull request to the merge queue Sep 12, 2024
@wdconinc
Copy link
Contributor Author

Now that detector_benchmark is fixed, I changed the required CI jobs to include check-geometry-configs / check-geometry-configs instead of check-geometry-configs (which now doesn't exist anymore). Other PRs will need to merge these changes or rebase after this is merged in main.

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 12, 2024
@veprbl veprbl added this pull request to the merge queue Sep 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 13, 2024
@veprbl veprbl added this pull request to the merge queue Sep 18, 2024
Merged via the queue into main with commit b7f1f3d Sep 18, 2024
114 of 115 checks passed
@veprbl veprbl deleted the reusable-workflows branch September 18, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Regarding build system, CI, CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants