feat: solana implementation #13
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add Solana account parsing tools.
* Add solana verification functionality * Add unit tests to Solana message verifier * Refactor * Solana msg verifier reshape (#4) * remove comment * Use Solana types from Solana crates We were using hand crafted Solana types for interacting with RPC. * refactor: make clippy happy * Add some traces to Solana msg verifier * Remove outdated todos * refactor: re-use already calculated variable * Clarify test code usage * Solana msg verifier, try till one program log matches gw event * Add note to axelar to review when in PR * fail if tx_id is not found in signatures * Always fail on chain at handler level * Handle errors in case a tx cannot be found (finish the handler) * Remove commented code * Use original type from solana-axelar repo * Ensure that we verify sender address in sol msg verifier * Do not panic on PartialEq * refactor: clippy * remove no longer used code * Add more tests definition to solana msg verify iteration logic --------- Co-authored-by: eloylp <[email protected]>
Were only intended during development to understand the API.
Co-authored-by: tilacog <[email protected]>
Co-authored-by: tilacog <[email protected]>
Co-authored-by: tilacog <[email protected]>
Co-authored-by: tilacog <[email protected]>
Co-authored-by: tilacog <[email protected]>
feat: ampd codebase update deps
feat: update multisig-prover with latest rkyv crate API updates
Cargo check was failing due to trailing white spaces. Signed-off-by: Guilherme Felipe da Silva <[email protected]>
Signed-off-by: Guilherme Felipe da Silva <[email protected]>
…ecoverable conversions
refactor: corrective PR after upstream sync
* update ampd handlers tomatch new Api's (WIP) * fix: comparison logic * fix comaprison (not allocate string) * fix: Be consistent in little endian * fix: commit missed files * fix: unify rkyv dep at workspace level * fix: avoid unwrap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR groups all the changes that will be upstreamed whenever the
ampdSolana implementation is done.The proposal is to squash this PR when merging.
This will also ensure both, our code and the PR format are OK with the contributing guidelines.
Todos
Steps to Test
Expected Behaviour
Other Notes