Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optimise storage access rate chore mechanism #160

Conversation

neutrinoks
Copy link
Contributor

  • Replaced chore mechanism on MultisigStorage with a new one to optimise average storage access rate

@neutrinoks neutrinoks requested a review from Rqnsom March 8, 2024 16:47
@neutrinoks neutrinoks self-assigned this Mar 8, 2024
@neutrinoks neutrinoks force-pushed the feat/optimise-storage-access-rate-chore-mechanism branch 4 times, most recently from d198a4d to 88e2915 Compare March 8, 2024 17:35
pallet/src/lib.rs Outdated Show resolved Hide resolved
@neutrinoks neutrinoks force-pushed the feat/optimise-storage-access-rate-chore-mechanism branch from 88e2915 to 2fa7fd4 Compare March 8, 2024 17:45
Rqnsom
Rqnsom previously approved these changes Mar 8, 2024
Copy link
Member

@Rqnsom Rqnsom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pallet/src/lib.rs Outdated Show resolved Hide resolved
@neutrinoks neutrinoks force-pushed the feat/optimise-storage-access-rate-chore-mechanism branch 2 times, most recently from 720f800 to 229391f Compare March 11, 2024 10:22
Rqnsom
Rqnsom previously approved these changes Mar 11, 2024
Copy link
Member

@Rqnsom Rqnsom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, looking nice

pallet/src/lib.rs Outdated Show resolved Hide resolved
pallet/src/lib.rs Show resolved Hide resolved
pallet/src/lib.rs Outdated Show resolved Hide resolved
pallet/src/lib.rs Outdated Show resolved Hide resolved
pallet/src/lib.rs Outdated Show resolved Hide resolved
pallet/src/lib.rs Show resolved Hide resolved
@neutrinoks neutrinoks force-pushed the feat/optimise-storage-access-rate-chore-mechanism branch from 229391f to a94ed30 Compare March 11, 2024 11:50
Copy link
Member

@Rqnsom Rqnsom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@neutrinoks neutrinoks merged commit 60f27ab into feat/main-milestone-three Mar 11, 2024
1 check passed
@neutrinoks neutrinoks deleted the feat/optimise-storage-access-rate-chore-mechanism branch March 11, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants