Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: functionality update for smove (multi-signer case) #162

Merged
merged 1 commit into from
Mar 25, 2024
Merged

feat: functionality update for smove (multi-signer case) #162

merged 1 commit into from
Mar 25, 2024

Conversation

neutrinoks
Copy link
Contributor

@neutrinoks neutrinoks commented Mar 25, 2024 •
edited
Loading

  • this modification is about enabling smove estimating gas in case of a multi-signer script execution
  • added a new method for creating a BalanceHandler instance with unlimited cheques

@neutrinoks neutrinoks requested a review from Rqnsom March 25, 2024 15:43
@neutrinoks neutrinoks self-assigned this Mar 25, 2024
Rqnsom
Rqnsom previously approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@Rqnsom Rqnsom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pallet/src/balance.rs Outdated Show resolved Hide resolved
pallet/src/balance.rs Outdated Show resolved Hide resolved
@neutrinoks neutrinoks force-pushed the feat/simplify-dry-run-execution branch from 55710ea to 46ca363 Compare March 25, 2024 16:34
Rqnsom
Rqnsom approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@Rqnsom Rqnsom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@neutrinoks neutrinoks merged commit d68cfec into feat/main-milestone-three Mar 25, 2024
1 check passed
@neutrinoks neutrinoks deleted the feat/simplify-dry-run-execution branch March 25, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rqnsom Rqnsom Rqnsom approved these changes

Assignees

@neutrinoks neutrinoks

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neutrinoks @Rqnsom