Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: optimise structuring and common used dev-utils #172

Merged
merged 1 commit into from
Apr 19, 2024
Merged

feat: optimise structuring and common used dev-utils #172

merged 1 commit into from
Apr 19, 2024

Conversation

neutrinoks
Copy link
Contributor

  • assets.rs got renamed into mock_utils.rs
  • commonly used methods and constants for creating test account IDs and addresses are centralised in mock_utils.rs
  • no usage of Public anymore, instead we directly use the trait Ss58Codec as trait bound

@neutrinoks neutrinoks requested a review from Rqnsom April 18, 2024 14:33
@neutrinoks neutrinoks self-assigned this Apr 18, 2024
@neutrinoks neutrinoks force-pushed the feat/mockup-benchmarking-cleanup branch from 11c5f71 to 245b93a Compare April 19, 2024 07:32
@neutrinoks neutrinoks force-pushed the feat/mockup-benchmarking-cleanup branch from 245b93a to 8c2ec8b Compare April 19, 2024 07:58
Rqnsom
Rqnsom approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@Rqnsom Rqnsom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pallet/src/benchmarking.rs Show resolved Hide resolved
Rqnsom
Rqnsom approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@Rqnsom Rqnsom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neutrinoks neutrinoks merged commit 9397967 into main Apr 19, 2024
1 check passed
@neutrinoks neutrinoks deleted the feat/mockup-benchmarking-cleanup branch April 19, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rqnsom Rqnsom Rqnsom approved these changes

Assignees

@neutrinoks neutrinoks

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neutrinoks @Rqnsom