chore: add gas handling doc, benchmark updates, few fixes #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neutrinoks
reviewed
May 20, 2024
- added gas handling solution - updated obsolete docs with the latest info
Rqnsom
force-pushed
the
doc/gas-handling-doc-and-other-updates
branch
2 times, most recently
from
a160860 to
949af15
Compare
neutrinoks
suggested changes
May 21, 2024
Rqnsom
force-pushed
the
doc/gas-handling-doc-and-other-updates
branch
from
949af15 to
0da6175
Compare
- replaced `u32` with `u64` for the `gas_limit` parameter in all extrinsics - updated benchmark tests trying to achieve similar gas cost for publishing modules and publishing bundles - tiny fixes in assets/move-projects
Rqnsom
force-pushed
the
doc/gas-handling-doc-and-other-updates
branch
from
0da6175 to
a9274d9
Compare
|
It's been tested on the node template, and everything works as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
u32withu64for thegas_limitparameter in allextrinsics
publishing modules and publishing bundles