Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lower the test balance in benchmark tests #197

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

Rqnsom
Copy link
Member

@Rqnsom Rqnsom commented Jun 18, 2024

Otherwise the test might attempt to add with overflow.

Otherwise the test might attempt to add with overflow.
@Rqnsom Rqnsom added the test Test updates label Jun 18, 2024
@Rqnsom Rqnsom requested a review from neutrinoks June 18, 2024 14:56
@Rqnsom Rqnsom self-assigned this Jun 18, 2024
Copy link
Contributor

@neutrinoks neutrinoks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still strange but if this helps, let's do it 👍

pallet/src/benchmarking.rs Show resolved Hide resolved
@Rqnsom
Copy link
Member Author

Rqnsom commented Jun 20, 2024

The root cause is that four sets of u128::MAX balances have a total balance which goes above u128::MAX.

@Rqnsom Rqnsom merged commit 89fe302 into main Jun 20, 2024
1 check passed
@Rqnsom Rqnsom deleted the fix/dont-use-max-balance branch June 20, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Test updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants