Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Iv curencies mappers #91

Closed
wants to merge 4 commits into from
Closed

Iv curencies mappers #91

wants to merge 4 commits into from

Conversation

35359595
Copy link

@35359595 35359595 commented Nov 3, 2023

  • balance tracker on pallet_move;
  • conversion methods for Move <-> Native accounts;
  • conversion tests;

@35359595 35359595 requested a review from Rqnsom November 3, 2023 22:51
@35359595 35359595 self-assigned this Nov 3, 2023
asmie
asmie reviewed Nov 6, 2023
View reviewed changes
tests/publish.rs Show resolved Hide resolved
@35359595 35359595 marked this pull request as ready for review November 6, 2023 19:31
@35359595 35359595 linked an issue Nov 6, 2023 that may be closed by this pull request
Move and Native adresses mappings #94
Closed
asmie
asmie reviewed Nov 7, 2023
View reviewed changes
src/lib.rs Show resolved Hide resolved
asmie
asmie reviewed Nov 7, 2023
View reviewed changes
src/lib.rs Outdated Show resolved Hide resolved
asmie
asmie approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@asmie asmie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Please squash commits upon merging and follow the Conventional Commits convention (for that squashed commit).
https://www.conventionalcommits.org/en/v1.0.0/

@35359595 35359595 force-pushed the iv-curencies-mappers branch from ab215d2 to 0e32fe0 Compare November 7, 2023 22:06
@35359595 35359595 mentioned this pull request Nov 8, 2023
Closed
@35359595 35359595 requested a review from Rqnsom November 21, 2023 20:45
@35359595
Copy link
Author

35359595 commented Dec 5, 2023

Abandoning in favour of #101

@35359595 35359595 closed this Dec 5, 2023
@35359595 35359595 deleted the iv-curencies-mappers branch December 5, 2023 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asmie asmie asmie approved these changes

@Rqnsom Rqnsom Awaiting requested review from Rqnsom

Assignees

@35359595 35359595

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move and Native adresses mappings
3 participants
@35359595 @asmie @Rqnsom