fix: add better error in market pallet for insufficient funds

eigerco · Jan 27, 2025 · 18eb23d · 18eb23d
1 parent 6d6043c
commit 18eb23d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/pallets/market/src/lib.rs b/pallets/market/src/lib.rs
@@ -1607,6 +1607,10 @@ pub mod pallet {
         amount: BalanceOf<T>,
     ) -> DispatchResult {
         BalanceTable::<T>::try_mutate(account_id, |balance| -> DispatchResult {
+            ensure!(
+                balance.locked >= amount,
+                Error::<T>::InsufficientLockedFunds
+            );
             balance.locked = balance
                 .locked
                 .checked_sub(&amount)

diff --git a/pallets/market/src/test.rs b/pallets/market/src/test.rs
@@ -1465,7 +1465,7 @@ fn test_unlock_funds() {
 
         assert_err!(
             unlock_funds::<Test>(&account::<Test>(PROVIDER), 60),
-            DispatchError::Arithmetic(ArithmeticError::Underflow)
+            Error::<Test>::InsufficientLockedFunds
         );
         assert_eq!(
             BalanceTable::<Test>::get(account::<Test>(PROVIDER)),