Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate out AddPiece pipeline step #489

Closed
Tracked by #347
th7nder opened this issue Oct 30, 2024 · 0 comments · Fixed by #483
Closed
Tracked by #347

Separate out AddPiece pipeline step #489

th7nder opened this issue Oct 30, 2024 · 0 comments · Fixed by #483
Milestone
Phase 2

Comments

@th7nder
Copy link
Contributor

th7nder commented Oct 30, 2024 

          Notes to consider / Food for thought:
  • We'll eventually need to make this AddPiece where each piece is added to the pipeline for first accumulation into a sector and then pre-commited — maybe we should add that step now and avoid more changes in this place, but the trade off is making this PR more complex. Raising these issues with comments works too
  • We'll probably be better off using a single AddPieces which has a batch, but I'm not sure

Originally posted by @jmg-duarte in #483 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Phase 2
Development

Successfully merging a pull request may close this issue.

feat: integrate pre-commit/create replica with extrinsic call on pipeline eigerco/polka-storage
1 participant
@th7nder