Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrate pre-commit/create replica with extrinsic call on pipeline #483

Merged
merged 29 commits into from
Nov 4, 2024

Conversation

th7nder
Copy link
Contributor

@th7nder th7nder commented Oct 28, 2024

Description

Fixes #476, #474, #472, #489.

$ cargo build --release -p storagext-cli -p polka-storage-provider-client -p polka-storage-provider-server 
$ just testnet
[..] wait a sec till charlie boots up
$ ./examples/rpc_publish.sh examples/random1024.piece 
2024-10-31T17:37:27.379069Z  INFO precommit: polka_storage_provider_server::pipeline: Successfully pre-commited sectors on-chain: [SectorsPreCommitted { owner: AccountId32([144, 181, 171, 32, 92, 105, 116, 201, 234, 132, 27, 230, 136, 134, 70, 51, 220, 156, 168, 163, 87, 132, 62, 234, 207, 35, 20, 100, 153, 101, 254, 34]), sectors: BoundedVec([SectorPreCommitInfo { seal_proof: StackedDRG2KiBV1P1, sector_number: 1, sealed_cid: BoundedVec([1, 130, 226, 3, 129, 232, 2, 32, 5, 125, 210, 204, 219, 75, 0, 180, 103, 151, 95, 121, 224, 168, 58, 191, 50, 30, 6, 234, 11, 245, 135, 92, 66, 222, 132, 236, 161, 47, 60, 88]), seal_randomness_height: 17, deal_ids: BoundedVec([0]), expiration: 270, unsealed_cid: BoundedVec([1, 129, 226, 3, 146, 32, 32, 237, 215, 149, 223, 20, 39, 44, 248, 21, 68, 160, 135, 164, 200, 31, 3, 93, 170, 161, 203, 134, 237, 192, 210, 52, 108, 54, 123, 108, 99, 110, 16]) }]) }]
2024-10-31T17:37:27.379118Z  INFO polka_storage_provider_server::pipeline: Precommit for sector 1 finished successfully.


Important points for reviewers

Add some additional resources that could help the reviewer with the
review. Like link to specs if implementing a protocol.

Checklist

@th7nder th7nder force-pushed the feat/476/pre-commit-pipeline branch from 56c2850 to d00debe Compare October 29, 2024 16:00
@th7nder th7nder marked this pull request as ready for review October 29, 2024 16:00
@th7nder th7nder added this to the Phase 2 milestone Oct 29, 2024
@th7nder th7nder self-assigned this Oct 29, 2024
@th7nder th7nder added the node-storage-provider Related to the storage provider node. label Oct 29, 2024
@th7nder th7nder requested review from jmg-duarte and cernicc October 29, 2024 16:00
Copy link
Contributor

@jmg-duarte jmg-duarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to me this is going in the right direction

cli/polka-storage-provider/server/src/main.rs Outdated Show resolved Hide resolved
cli/polka-storage-provider/server/src/main.rs Outdated Show resolved Hide resolved
cli/polka-storage-provider/server/src/main.rs Outdated Show resolved Hide resolved
cli/polka-storage-provider/server/src/rpc.rs Outdated Show resolved Hide resolved
cli/polka-storage-provider/server/src/pipeline.rs Outdated Show resolved Hide resolved
cli/polka-storage-provider/server/src/pipeline.rs Outdated Show resolved Hide resolved
cli/polka-storage-provider/server/src/pipeline.rs Outdated Show resolved Hide resolved
cli/polka-storage-provider/server/src/pipeline.rs Outdated Show resolved Hide resolved
cli/polka-storage-provider/server/src/pipeline.rs Outdated Show resolved Hide resolved
@th7nder th7nder force-pushed the feat/476/pre-commit-pipeline branch from d00debe to 9e1d2dd Compare October 29, 2024 23:56
Copy link
Contributor

@jmg-duarte jmg-duarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right track, some items for discussion and some things to do.

Great job 🚀

cli/polka-storage-provider/server/src/db.rs Outdated Show resolved Hide resolved
cli/polka-storage-provider/server/src/db.rs Outdated Show resolved Hide resolved
cli/polka-storage-provider/server/src/db.rs Show resolved Hide resolved
cli/polka-storage-provider/server/src/db.rs Outdated Show resolved Hide resolved
cli/polka-storage-provider/server/src/main.rs Outdated Show resolved Hide resolved
cli/polka-storage-provider/server/src/rpc.rs Outdated Show resolved Hide resolved
lib/polka-storage-proofs/src/porep/sealer.rs Outdated Show resolved Hide resolved
lib/polka-storage-proofs/src/porep/sealer.rs Outdated Show resolved Hide resolved
primitives/commitment/src/piece.rs Outdated Show resolved Hide resolved
lib/polka-storage-proofs/src/porep/sealer.rs Show resolved Hide resolved
@jmg-duarte jmg-duarte mentioned this pull request Oct 31, 2024
7 tasks
This was referenced Oct 31, 2024
Copy link
Contributor

@jmg-duarte jmg-duarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing progress

cli/polka-storage-provider/server/src/db.rs Outdated Show resolved Hide resolved
cli/polka-storage-provider/server/src/db.rs Outdated Show resolved Hide resolved
cli/polka-storage-provider/server/src/rpc.rs Outdated Show resolved Hide resolved
lib/polka-storage-proofs/src/porep/sealer.rs Outdated Show resolved Hide resolved
lib/polka-storage-proofs/src/porep/sealer.rs Outdated Show resolved Hide resolved
cli/polka-storage-provider/server/src/pipeline/mod.rs Outdated Show resolved Hide resolved
@th7nder th7nder force-pushed the feat/476/pre-commit-pipeline branch from bc6301b to 3fc9f28 Compare November 4, 2024 10:03
@th7nder th7nder added the ready for review Review is needed label Nov 4, 2024
@th7nder th7nder requested a review from jmg-duarte November 4, 2024 10:03
@th7nder th7nder added ready for review Review is needed and removed ready for review Review is needed labels Nov 4, 2024
@th7nder th7nder force-pushed the feat/476/pre-commit-pipeline branch from 50a130a to 614aa75 Compare November 4, 2024 10:59
@th7nder th7nder added ready for review Review is needed and removed ready for review Review is needed labels Nov 4, 2024
@th7nder th7nder added ready for review Review is needed and removed ready for review Review is needed labels Nov 4, 2024
Copy link
Member

@cernicc cernicc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 💪

@jmg-duarte jmg-duarte enabled auto-merge (squash) November 4, 2024 13:10
@jmg-duarte jmg-duarte merged commit af51a9b into develop Nov 4, 2024
5 checks passed
@jmg-duarte jmg-duarte deleted the feat/476/pre-commit-pipeline branch November 4, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
node-storage-provider Related to the storage provider node. ready for review Review is needed
Projects
None yet
3 participants