Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(market): enable deal state retrieval #609

Merged
merged 6 commits into from
Nov 26, 2024

Conversation

cernicc
Copy link
Member

@cernicc cernicc commented Nov 25, 2024

Description

Add deal retrieval to the storagext lib and cli.

Published deal output:

Deal Proposal { piece_cid: baga6ea4seaqbfhdvmk5qygevit25ztjwl7voyikb5k2fqcl2lsuefhaqtukuiii, piece_size: 2048, provider: 5FLSigC9HGRKVhB9FiEo4Y3koPsNmBmLJbpXg2mp1hXcS59Y, client: 5GrwvaEF5zXb26Fz9rcQpDWS57CtERHpNehXCPcNoHGKutQY, label: , start_block: 200, end_block: 250, storage_price_per_block: 500, provider_collateral: 1250, state: Published }

Activated deal output:

Deal Proposal { piece_cid: baga6ea4seaqbfhdvmk5qygevit25ztjwl7voyikb5k2fqcl2lsuefhaqtukuiii, piece_size: 2048, provider: 5FLSigC9HGRKVhB9FiEo4Y3koPsNmBmLJbpXg2mp1hXcS59Y, client: 5GrwvaEF5zXb26Fz9rcQpDWS57CtERHpNehXCPcNoHGKutQY, label: , start_block: 200, end_block: 250, storage_price_per_block: 500, provider_collateral: 1250, state: Active({ sector_number: 1, sector_start_block: 37, last_updated_block: None, slash_block: None }) }

@cernicc cernicc linked an issue Nov 25, 2024 that may be closed by this pull request
@cernicc cernicc force-pushed the feat/501/expose-deal-status-over-rpc branch from 16a5183 to 004985f Compare November 26, 2024 08:26
@cernicc cernicc self-assigned this Nov 26, 2024
@cernicc cernicc force-pushed the feat/501/expose-deal-status-over-rpc branch from 2368dd1 to 95c68f4 Compare November 26, 2024 09:56
@cernicc cernicc marked this pull request as ready for review November 26, 2024 09:58
Copy link
Contributor

@aidan46 aidan46 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation LGTM. Could you update the storagext CLI documentation to reflect this change?

@cernicc cernicc requested a review from aidan46 November 26, 2024 10:31
th7nder
th7nder previously approved these changes Nov 26, 2024
@jmg-duarte jmg-duarte changed the title feat(market): enable deal retrieval feat(market): enable deal state retrieval Nov 26, 2024
@cernicc cernicc requested a review from th7nder November 26, 2024 12:38
aidan46
aidan46 previously approved these changes Nov 26, 2024
@jmg-duarte jmg-duarte added the ready for review Review is needed label Nov 26, 2024
@jmg-duarte jmg-duarte added this to the Phase 3 milestone Nov 26, 2024
th7nder
th7nder previously approved these changes Nov 26, 2024
@cernicc cernicc dismissed stale reviews from th7nder and aidan46 via 65bf3ef November 26, 2024 13:16
@cernicc cernicc added ready for review Review is needed and removed ready for review Review is needed labels Nov 26, 2024
@cernicc cernicc requested review from aidan46 and th7nder November 26, 2024 13:19
@cernicc cernicc enabled auto-merge (squash) November 26, 2024 13:25
@cernicc cernicc merged commit 76f79ce into develop Nov 26, 2024
5 checks passed
@cernicc cernicc deleted the feat/501/expose-deal-status-over-rpc branch November 26, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Review is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants