-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(market): enable deal state retrieval #609
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cernicc
force-pushed
the
feat/501/expose-deal-status-over-rpc
branch
from
November 26, 2024 08:26
16a5183
to
004985f
Compare
cernicc
force-pushed
the
feat/501/expose-deal-status-over-rpc
branch
from
November 26, 2024 09:56
2368dd1
to
95c68f4
Compare
aidan46
requested changes
Nov 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation LGTM. Could you update the storagext CLI documentation to reflect this change?
th7nder
previously approved these changes
Nov 26, 2024
jmg-duarte
changed the title
feat(market): enable deal retrieval
feat(market): enable deal state retrieval
Nov 26, 2024
aidan46
previously approved these changes
Nov 26, 2024
th7nder
previously approved these changes
Nov 26, 2024
cernicc
added
ready for review
Review is needed
and removed
ready for review
Review is needed
labels
Nov 26, 2024
aidan46
approved these changes
Nov 26, 2024
th7nder
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add deal retrieval to the storagext lib and cli.
Published deal output:
Activated deal output: