feat: replace Currency logic with Market in the SP pallet #689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmg-duarte
added
pallet-market
aidan46
reviewed
Jan 22, 2025
cernicc
added
ready for review
th7nder
approved these changes
Jan 22, 2025
|
No one noticed the PR name was wrong 💀 my bad but too late now |
jmg-duarte
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Stops using the
Currencytrait for handling balances. Centralizing everything in the Market pallet.Important points for reviewers
If you find uses of
Balancesinside the SP pallet flag them down!