Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add p2p resolver example #696

Merged
merged 8 commits into from
Jan 31, 2025
Merged

feat: Add p2p resolver example #696

merged 8 commits into from
Jan 31, 2025

Conversation

aidan46
Copy link
Contributor

@aidan46 aidan46 commented Jan 23, 2025 •
edited
Loading

Description

Add an example for resolving a Peer ID to a multiaddr. I have created a new binary for this in the root, I am aware that this is not the place to put it but I am not sure where I should place it.

This PR should be merged after #686

@aidan46 aidan46 self-assigned this Jan 23, 2025
@aidan46 aidan46 added the enhancement New feature or request label Jan 23, 2025
@aidan46 aidan46 added this to the Phase 3 milestone Jan 23, 2025
@aidan46 aidan46 linked an issue Jan 23, 2025 that may be closed by this pull request
feat: Add p2p discovery example #687
Closed
Base automatically changed from 682-featpolka-storage-provider-add-auto-reregistration-for-p2p-node to develop January 24, 2025 11:46
@aidan46 aidan46 force-pushed the 687-feat-add-p2p-discovery-example branch 3 times, most recently from 04e38c8 to 9693115 Compare January 27, 2025 07:56
@aidan46 aidan46 marked this pull request as ready for review January 27, 2025 09:59
@aidan46 aidan46 added the ready for review Review is needed label Jan 27, 2025
@aidan46 aidan46 force-pushed the 687-feat-add-p2p-discovery-example branch from 9c6c72b to c9556f3 Compare January 28, 2025 06:28
jmg-duarte
jmg-duarte reviewed Jan 28, 2025
View reviewed changes
Copy link
Contributor

@jmg-duarte jmg-duarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have created a new binary for this in the root, I am aware that this is not the place to put it but I am not sure where I should place it.

Maybe storage-provider/client/examples

examples/peer-resolver/src/main.rs Outdated Show resolved Hide resolved
examples/peer-resolver/src/main.rs Outdated Show resolved Hide resolved
th7nder
th7nder previously approved these changes Jan 30, 2025
View reviewed changes
jmg-duarte
jmg-duarte previously approved these changes Jan 30, 2025
View reviewed changes
@jmg-duarte jmg-duarte enabled auto-merge (squash) January 30, 2025 11:31
@jmg-duarte jmg-duarte force-pushed the 687-feat-add-p2p-discovery-example branch from 97b8b2e to 7f1be01 Compare January 30, 2025 11:31
@jmg-duarte jmg-duarte added ready for review Review is needed and removed ready for review Review is needed labels Jan 30, 2025
@aidan46 aidan46 dismissed stale reviews from th7nder and jmg-duarte via dc1526f January 31, 2025 04:55
@aidan46 aidan46 added ready for review Review is needed and removed ready for review Review is needed labels Jan 31, 2025
@aidan46 aidan46 added ready for review Review is needed and removed ready for review Review is needed labels Jan 31, 2025
@jmg-duarte jmg-duarte merged commit a82fea0 into develop Jan 31, 2025
6 checks passed
@jmg-duarte jmg-duarte deleted the 687-feat-add-p2p-discovery-example branch January 31, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmg-duarte jmg-duarte jmg-duarte approved these changes

@th7nder th7nder th7nder approved these changes

Assignees

@aidan46 aidan46

Labels
enhancement New feature or request ready for review Review is needed
Projects
None yet
Milestone
Phase 3
Development

Successfully merging this pull request may close these issues.

feat: Add p2p discovery example
3 participants
@aidan46 @th7nder @jmg-duarte