Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Unlock pre commit desposit after proving #697

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

aidan46
Copy link
Contributor

@aidan46 aidan46 commented Jan 23, 2025

Description

Unlock the pre-commit deposit after the sector has been proven. Before this, the pre-commit deposit funds were never returned to the storage provider. The tests have been updated to reflect this change.

References:
FC 1
FC 2

@aidan46 aidan46 added the bug Something isn't working label Jan 23, 2025
@aidan46 aidan46 self-assigned this Jan 23, 2025
@aidan46 aidan46 added the ready for review Review is needed label Jan 23, 2025
jmg-duarte
jmg-duarte previously approved these changes Jan 23, 2025
@jmg-duarte jmg-duarte added this to the Phase 3 milestone Jan 23, 2025
cernicc
cernicc previously approved these changes Jan 23, 2025
@aidan46 aidan46 dismissed stale reviews from cernicc and jmg-duarte via 3784c05 January 23, 2025 11:59
@aidan46 aidan46 added ready for review Review is needed and removed ready for review Review is needed labels Jan 23, 2025
@aidan46 aidan46 requested review from jmg-duarte and cernicc January 23, 2025 11:59
@aidan46 aidan46 enabled auto-merge (squash) January 23, 2025 12:01
@aidan46 aidan46 added ready for review Review is needed and removed ready for review Review is needed labels Jan 23, 2025
Copy link
Contributor

@jmg-duarte jmg-duarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@aidan46 aidan46 merged commit fd17d46 into develop Jan 23, 2025
5 checks passed
@aidan46 aidan46 deleted the fix/unlock-pre-commit-deposit-after-proving branch January 23, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready for review Review is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants