-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: mater car reader read_block_metadata #706
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cernicc
added
ready for review
Review is needed
and removed
ready for review
Review is needed
labels
Jan 28, 2025
jmg-duarte
reviewed
Jan 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but there's some things I think could be improved
cernicc
added
ready for review
Review is needed
and removed
ready for review
Review is needed
labels
Jan 28, 2025
cernicc
changed the title
feat: mater car reader block skipping
feat: mater car reader read_block_metadata
Jan 28, 2025
jmg-duarte
approved these changes
Jan 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I grow up, I want to be like you 🚀
th7nder
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enable mater car readers to be able to read the blocks metadata while reading the car archive. If the
read_block_metadata
is used, that means that the block content is not loaded into memory and only the block's metadata is returned.This is needed for the storage provider server for when the sector is being indexed. The provider will index the sectors after they are successfully prove committed. The indexing process opens unesaled sector files and reads the car blocks directly from the file. For indexing purposes, we don't need the content in the block. This pr enables the sector indexer to only read the metadata of the car block and saves that to the index.
Checklist