-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for 8MiB sector size #708
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking until #709 is addressed
72575eb
to
5177c52
Compare
3dfd11b
to
e95fd63
Compare
99fa84d
to
a5aa082
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
f0932e8
to
5135860
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
Partially fixes #664. As it only adds 8MiB support as an example.
Important points for reviewers
It successfully creates 8MiB sector,
but still cannot store arbitrary files, there is another issue with padding. I'm investigating in another task.(fixed in #709) and allows to store arbitrary files. Maat test has been adjusted for that, along with other dependencies that were not creating CAR files properly.Checklist