Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for 8MiB sector size #708

Merged
merged 13 commits into from
Jan 31, 2025
Merged

Conversation

th7nder
Copy link
Contributor

@th7nder th7nder commented Jan 29, 2025

Description

Partially fixes #664. As it only adds 8MiB support as an example.

Important points for reviewers

It successfully creates 8MiB sector, but still cannot store arbitrary files, there is another issue with padding. I'm investigating in another task. (fixed in #709) and allows to store arbitrary files. Maat test has been adjusted for that, along with other dependencies that were not creating CAR files properly.

Checklist

  • Are there important points that reviewers should know?
    • If yes, which ones?
  • Make sure that you described what this change does.
  • If there are follow-ups, have you created issues for them?
  • Have you tested this solution?
  • Were there any alternative implementations considered?
  • Did you document new (or modified) APIs?

@th7nder th7nder added the enhancement New feature or request label Jan 29, 2025
@th7nder th7nder self-assigned this Jan 29, 2025
@th7nder th7nder added this to the Phase 3 milestone Jan 29, 2025
@th7nder th7nder marked this pull request as ready for review January 29, 2025 14:24
@th7nder th7nder added the ready for review Review is needed label Jan 29, 2025
Copy link
Contributor

@jmg-duarte jmg-duarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking until #709 is addressed

@th7nder th7nder force-pushed the feat/664/bigger-sector-sizes branch from 72575eb to 5177c52 Compare January 30, 2025 10:59
@th7nder th7nder added ready for review Review is needed and removed ready for review Review is needed labels Jan 30, 2025
@th7nder th7nder requested a review from jmg-duarte January 30, 2025 11:57
@th7nder th7nder force-pushed the feat/664/bigger-sector-sizes branch from 3dfd11b to e95fd63 Compare January 30, 2025 12:02
@th7nder th7nder added ready for review Review is needed and removed ready for review Review is needed labels Jan 30, 2025
jmg-duarte
jmg-duarte previously approved these changes Jan 30, 2025
@th7nder th7nder enabled auto-merge (squash) January 30, 2025 14:21
primitives/src/proofs.rs Outdated Show resolved Hide resolved
primitives/src/proofs.rs Outdated Show resolved Hide resolved
@th7nder th7nder force-pushed the feat/664/bigger-sector-sizes branch from 99fa84d to a5aa082 Compare January 31, 2025 08:32
@th7nder th7nder added ready for review Review is needed and removed ready for review Review is needed labels Jan 31, 2025
@th7nder th7nder requested review from jmg-duarte and aidan46 January 31, 2025 09:25
Copy link
Contributor

@aidan46 aidan46 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jmg-duarte jmg-duarte force-pushed the feat/664/bigger-sector-sizes branch from f0932e8 to 5135860 Compare January 31, 2025 09:48
@jmg-duarte jmg-duarte added ready for review Review is needed and removed ready for review Review is needed labels Jan 31, 2025
Copy link
Contributor

@jmg-duarte jmg-duarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@th7nder th7nder merged commit 10295d7 into develop Jan 31, 2025
6 checks passed
@th7nder th7nder deleted the feat/664/bigger-sector-sizes branch January 31, 2025 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready for review Review is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bigger Sector Sizes
3 participants