Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: resolve rococo-runtime error #719

Merged
merged 2 commits into from
Feb 3, 2025

Conversation

th7nder
Copy link
Contributor

@th7nder th7nder commented Feb 2, 2025

Description

There was an issue.

---- real_world_use_case stdout ----
thread 'real_world_use_case' panicked at maat/tests/real_world.rs:290:63:
called `Result::unwrap()` on an `Err` value: GeneratorError(ProviderError(FileGenerationFailed(Error: 
   0: Invalid input: Rococo development wasm not available

Now it's gone.

Important points for reviewers

That's because in Nix supplied polkadot binary, SKIP_WASM_BUILD=1 is disabled.
Needed to generate chainspec by directly downloading polkadot binary (https://github.com/paritytech/polkadot-sdk/releases/download/polkadot-stable2412-1/polkadot) and running /polkadot build-spec --chain rococo-local > rococo-local.json. We won't need to add chain_spec_path` when paritytech/polkadot-sdk#7008 is merged and nix updated.

Additionally,

  • we now follow https://github.com/andresilva/polkadot.nix/tree/master instead of nixpkgs/nixos-unstable, as it's the source of truth for it anyways and gets updated faster.

Checklist

  • Are there important points that reviewers should know?
    • If yes, which ones?
  • Make sure that you described what this change does.
  • If there are follow-ups, have you created issues for them?
  • Have you tested this solution?

@th7nder th7nder changed the title feat: add caching for porep params in maat feat: resolve rococo-runtime error and add caching for maat Feb 2, 2025
@th7nder th7nder changed the title feat: resolve rococo-runtime error and add caching for maat feat: resolve rococo-runtime error and add param caching for maat Feb 2, 2025
@th7nder th7nder force-pushed the fix/no-ref/rococo-wasm-not-available branch from 374fc69 to ebc6eaa Compare February 3, 2025 09:37
@th7nder th7nder changed the title feat: resolve rococo-runtime error and add param caching for maat feat: resolve rococo-runtime error Feb 3, 2025
@jmg-duarte jmg-duarte added the ready for review Review is needed label Feb 3, 2025
@th7nder th7nder enabled auto-merge (squash) February 3, 2025 10:48
@th7nder th7nder self-assigned this Feb 3, 2025
@th7nder th7nder merged commit 6da1898 into develop Feb 3, 2025
6 checks passed
@th7nder th7nder deleted the fix/no-ref/rococo-wasm-not-available branch February 3, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Review is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants