fixup bicycle hackernews tests #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #378 +/- ##
==========================================
+ Coverage 58.94% 60.03% +1.09%
==========================================
Files 7 7
Lines 1023 1061 +38
==========================================
+ Hits 603 637 +34
- Misses 353 354 +1
- Partials 67 70 +3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If approved, this PR will:
fix(proto): add duration_ms and bike_model to bicycle_rental model
Add two new attributes
duration_msandbike_modelthat has been added to the public dataset bicycle rental. Integration tests now pass again.fix: remove no longer existing public data hacker_news.stories
The stories table in the public hacker news dataset have been removed. Removing references to it.