chore: bump sage

.sage/go.mod

@@ -2,4 +2,4 @@ module sage
 
 go 1.17
 
-require go.einride.tech/sage v0.216.0
+require go.einride.tech/sage v0.284.0

.sage/go.sum

@@ -1,2 +1,2 @@
-go.einride.tech/sage v0.216.0 h1:gjzooF3mJaKi2+BxgZ94OnCL60CouTGZXj6gclZwQSQ=
-go.einride.tech/sage v0.216.0/go.mod h1:EzV5uciFX7/2ho8EKB5K9JghOfXIxlzs694b+Tkl5GQ=
+go.einride.tech/sage v0.284.0 h1:dcDnX4HgaCEcufhYjGEHlbCQip0jgsfuzVOkCg7WGig=
+go.einride.tech/sage v0.284.0/go.mod h1:EzV5uciFX7/2ho8EKB5K9JghOfXIxlzs694b+Tkl5GQ=

.sage/main.go

@@ -8,8 +8,7 @@ import (
 	"go.einride.tech/sage/tools/sggit"
 	"go.einride.tech/sage/tools/sggo"
 	"go.einride.tech/sage/tools/sggolangcilint"
-	"go.einride.tech/sage/tools/sggoreview"
-	"go.einride.tech/sage/tools/sgmarkdownfmt"
+	"go.einride.tech/sage/tools/sgmdformat"
 	"go.einride.tech/sage/tools/sgyamlfmt"
 )
 
@@ -28,7 +27,7 @@ func main() {
 }
 
 func All(ctx context.Context) error {
-	sg.Deps(ctx, ConvcoCheck, GoLint, GoReview, GoTest, FormatMarkdown, FormatYAML)
+	sg.Deps(ctx, ConvcoCheck, GoLint, GoTest, FormatMarkdown, FormatYAML)
 	sg.SerialDeps(ctx, Proto.All, TypescriptLint)
 	sg.SerialDeps(ctx, GoModTidy, GitVerifyNoDiff)
 	return nil
@@ -49,19 +48,19 @@ func GoTest(ctx context.Context) error {
 	return sggo.TestCommand(ctx).Run()
 }
 
-func GoReview(ctx context.Context) error {
-	sg.Logger(ctx).Println("reviewing Go files...")
-	return sggoreview.Command(ctx, "-c", "1", "./...").Run()
-}
-
 func GoLint(ctx context.Context) error {
 	sg.Logger(ctx).Println("linting Go files...")
 	return sggolangcilint.Run(ctx)
 }
 
+func GoLintFix(ctx context.Context) error {
+	sg.Logger(ctx).Println("fixing Go files...")
+	return sggolangcilint.Fix(ctx)
+}
+
 func FormatMarkdown(ctx context.Context) error {
 	sg.Logger(ctx).Println("formatting Markdown files...")
-	return sgmarkdownfmt.Command(ctx, "-w", ".").Run()
+	return sgmdformat.Command(ctx).Run()
 }
 
 func ConvcoCheck(ctx context.Context) error {

CODE_OF_CONDUCT.md

@@ -1,87 +1,128 @@
-Contributor Covenant Code of Conduct
-====================================
+# Contributor Covenant Code of Conduct
 
-Our Pledge
-----------
+## Our Pledge
 
-We as members, contributors, and leaders pledge to make participation in our community a harassment-free experience for everyone, regardless of age, body size, visible or invisible disability, ethnicity, sex characteristics, gender identity and expression, level of experience, education, socio-economic status, nationality, personal appearance, race, religion, or sexual identity and orientation.
+We as members, contributors, and leaders pledge to make participation in our
+community a harassment-free experience for everyone, regardless of age, body
+size, visible or invisible disability, ethnicity, sex characteristics, gender
+identity and expression, level of experience, education, socio-economic status,
+nationality, personal appearance, race, religion, or sexual identity and
+orientation.
 
-We pledge to act and interact in ways that contribute to an open, welcoming, diverse, inclusive, and healthy community.
+We pledge to act and interact in ways that contribute to an open, welcoming,
+diverse, inclusive, and healthy community.
 
-Our Standards
--------------
+## Our Standards
 
-Examples of behavior that contributes to a positive environment for our community include:
+Examples of behavior that contributes to a positive environment for our
+community include:
 
--	Demonstrating empathy and kindness toward other people
--	Being respectful of differing opinions, viewpoints, and experiences
--	Giving and gracefully accepting constructive feedback
--	Accepting responsibility and apologizing to those affected by our mistakes, and learning from the experience
--	Focusing on what is best not just for us as individuals, but for the overall community
+- Demonstrating empathy and kindness toward other people
+- Being respectful of differing opinions, viewpoints, and experiences
+- Giving and gracefully accepting constructive feedback
+- Accepting responsibility and apologizing to those affected by our mistakes,
+  and learning from the experience
+- Focusing on what is best not just for us as individuals, but for the overall
+  community
 
 Examples of unacceptable behavior include:
 
--	The use of sexualized language or imagery, and sexual attention or advances of any kind
--	Trolling, insulting or derogatory comments, and personal or political attacks
--	Public or private harassment
--	Publishing others' private information, such as a physical or email address, without their explicit permission
--	Other conduct which could reasonably be considered inappropriate in a professional setting
+- The use of sexualized language or imagery, and sexual attention or advances of
+  any kind
+- Trolling, insulting or derogatory comments, and personal or political attacks
+- Public or private harassment
+- Publishing others' private information, such as a physical or email address,
+  without their explicit permission
+- Other conduct which could reasonably be considered inappropriate in a
+  professional setting
 
-Enforcement Responsibilities
-----------------------------
+## Enforcement Responsibilities
 
-Community leaders are responsible for clarifying and enforcing our standards of acceptable behavior and will take appropriate and fair corrective action in response to any behavior that they deem inappropriate, threatening, offensive, or harmful.
+Community leaders are responsible for clarifying and enforcing our standards of
+acceptable behavior and will take appropriate and fair corrective action in
+response to any behavior that they deem inappropriate, threatening, offensive,
+or harmful.
 
-Community leaders have the right and responsibility to remove, edit, or reject comments, commits, code, wiki edits, issues, and other contributions that are not aligned to this Code of Conduct, and will communicate reasons for moderation decisions when appropriate.
+Community leaders have the right and responsibility to remove, edit, or reject
+comments, commits, code, wiki edits, issues, and other contributions that are
+not aligned to this Code of Conduct, and will communicate reasons for moderation
+decisions when appropriate.
 
-Scope
------
+## Scope
 
-This Code of Conduct applies within all community spaces, and also applies when an individual is officially representing the community in public spaces. Examples of representing our community include using an official e-mail address, posting via an official social media account, or acting as an appointed representative at an online or offline event.
+This Code of Conduct applies within all community spaces, and also applies when
+an individual is officially representing the community in public spaces.
+Examples of representing our community include using an official e-mail address,
+posting via an official social media account, or acting as an appointed
+representative at an online or offline event.
 
-Enforcement
------------
+## Enforcement
 
-Instances of abusive, harassing, or otherwise unacceptable behavior may be reported to the community leaders responsible for enforcement at [email protected].
+Instances of abusive, harassing, or otherwise unacceptable behavior may be
+reported to the community leaders responsible for enforcement at
+[email protected].
 
 All complaints will be reviewed and investigated promptly and fairly.
 
-All community leaders are obligated to respect the privacy and security of the reporter of any incident.
+All community leaders are obligated to respect the privacy and security of the
+reporter of any incident.
 
-Enforcement Guidelines
-----------------------
+## Enforcement Guidelines
 
-Community leaders will follow these Community Impact Guidelines in determining the consequences for any action they deem in violation of this Code of Conduct:
+Community leaders will follow these Community Impact Guidelines in determining
+the consequences for any action they deem in violation of this Code of Conduct:
 
 ### 1. Correction
 
-**Community Impact**: Use of inappropriate language or other behavior deemed unprofessional or unwelcome in the community.
+**Community Impact**: Use of inappropriate language or other behavior deemed
+unprofessional or unwelcome in the community.
 
-**Consequence**: A private, written warning from community leaders, providing clarity around the nature of the violation and an explanation of why the behavior was inappropriate. A public apology may be requested.
+**Consequence**: A private, written warning from community leaders, providing
+clarity around the nature of the violation and an explanation of why the
+behavior was inappropriate. A public apology may be requested.
 
 ### 2. Warning
 
-**Community Impact**: A violation through a single incident or series of actions.
+**Community Impact**: A violation through a single incident or series of
+actions.
 
-**Consequence**: A warning with consequences for continued behavior. No interaction with the people involved, including unsolicited interaction with those enforcing the Code of Conduct, for a specified period of time. This includes avoiding interactions in community spaces as well as external channels like social media. Violating these terms may lead to a temporary or permanent ban.
+**Consequence**: A warning with consequences for continued behavior. No
+interaction with the people involved, including unsolicited interaction with
+those enforcing the Code of Conduct, for a specified period of time. This
+includes avoiding interactions in community spaces as well as external channels
+like social media. Violating these terms may lead to a temporary or permanent
+ban.
 
 ### 3. Temporary Ban
 
-**Community Impact**: A serious violation of community standards, including sustained inappropriate behavior.
+**Community Impact**: A serious violation of community standards, including
+sustained inappropriate behavior.
 
-**Consequence**: A temporary ban from any sort of interaction or public communication with the community for a specified period of time. No public or private interaction with the people involved, including unsolicited interaction with those enforcing the Code of Conduct, is allowed during this period. Violating these terms may lead to a permanent ban.
+**Consequence**: A temporary ban from any sort of interaction or public
+communication with the community for a specified period of time. No public or
+private interaction with the people involved, including unsolicited interaction
+with those enforcing the Code of Conduct, is allowed during this period.
+Violating these terms may lead to a permanent ban.
 
 ### 4. Permanent Ban
 
-**Community Impact**: Demonstrating a pattern of violation of community standards, including sustained inappropriate behavior, harassment of an individual, or aggression toward or disparagement of classes of individuals.
+**Community Impact**: Demonstrating a pattern of violation of community
+standards, including sustained inappropriate behavior, harassment of an
+individual, or aggression toward or disparagement of classes of individuals.
 
-**Consequence**: A permanent ban from any sort of public interaction within the community.
+**Consequence**: A permanent ban from any sort of public interaction within the
+community.
 
-Attribution
------------
+## Attribution
 
-This Code of Conduct is adapted from the [Contributor Covenant](https://www.contributor-covenant.org), version 2.0, available at https://www.contributor-covenant.org/version/2/0/code_of_conduct.html.
+This Code of Conduct is adapted from the
+[Contributor Covenant](https://www.contributor-covenant.org), version 2.0,
+available at
+https://www.contributor-covenant.org/version/2/0/code_of_conduct.html.
 
-Community Impact Guidelines were inspired by [Mozilla's code of conduct enforcement ladder](https://github.com/mozilla/diversity).
+Community Impact Guidelines were inspired by
+[Mozilla's code of conduct enforcement ladder](https://github.com/mozilla/diversity).
 
-For answers to common questions about this code of conduct, see the FAQ at https://www.contributor-covenant.org/faq. Translations are available at https://www.contributor-covenant.org/translations.
+For answers to common questions about this code of conduct, see the FAQ at
+https://www.contributor-covenant.org/faq. Translations are available at
+https://www.contributor-covenant.org/translations.

Makefile

@@ -67,14 +67,14 @@ git-verify-no-diff: $(sagefile)
 go-lint: $(sagefile)
 	@$(sagefile) GoLint
 
+.PHONY: go-lint-fix
+go-lint-fix: $(sagefile)
+	@$(sagefile) GoLintFix
+
 .PHONY: go-mod-tidy
 go-mod-tidy: $(sagefile)
 	@$(sagefile) GoModTidy
 
-.PHONY: go-review
-go-review: $(sagefile)
-	@$(sagefile) GoReview
-
 .PHONY: go-test
 go-test: $(sagefile)
 	@$(sagefile) GoTest

README.md

@@ -1,14 +1,18 @@
-protoc-gen-typescript-http
-==========================
+# protoc-gen-typescript-http
 
-Generates Typescript types and service clients from protobuf definitions annotated with [http rules](https://github.com/googleapis/googleapis/blob/master/google/api/http.proto). The generated types follow the [canonical JSON encoding](https://developers.google.com/protocol-buffers/docs/proto3#json).
+Generates Typescript types and service clients from protobuf definitions
+annotated with
+[http rules](https://github.com/googleapis/googleapis/blob/master/google/api/http.proto).
+The generated types follow the
+[canonical JSON encoding](https://developers.google.com/protocol-buffers/docs/proto3#json).
 
-**Experimental**: This library is under active development and breaking changes to config files, APIs and generated code are expected between releases.
+**Experimental**: This library is under active development and breaking changes
+to config files, APIs and generated code are expected between releases.
 
-Using the plugin
-----------------
+## Using the plugin
 
-For examples of correctly annotated protobuf defintions and the generated code, look at [examples](./examples).
+For examples of correctly annotated protobuf defintions and the generated code,
+look at [examples](./examples).
 
 ### Install the plugin
 
@@ -26,9 +30,10 @@ protoc
   [.proto files ...]
 ```
 
----
+______________________________________________________________________
 
-The generated clients can be used with any HTTP client that returns a Promise containing JSON data.
+The generated clients can be used with any HTTP client that returns a Promise
+containing JSON data.
 
 ```typescript
 const rootUrl = "...";

internal/httprule/rule.go

@@ -39,8 +39,8 @@ func ParseRule(httpRule *annotations.HttpRule) (Rule, error) {
 	if err != nil {
 		return Rule{}, err
 	}
-	additional := make([]Rule, len(httpRule.AdditionalBindings))
-	for i, r := range httpRule.AdditionalBindings {
+	additional := make([]Rule, len(httpRule.GetAdditionalBindings()))
+	for i, r := range httpRule.GetAdditionalBindings() {
 		a, err := ParseRule(r)
 		if err != nil {
 			return Rule{}, fmt.Errorf("parse additional binding %d: %w", i, err)
@@ -50,7 +50,7 @@ func ParseRule(httpRule *annotations.HttpRule) (Rule, error) {
 	return Rule{
 		Method:          method,
 		Template:        template,
-		Body:            httpRule.Body,
+		Body:            httpRule.GetBody(),
 		AdditionalRules: additional,
 	}, nil
 }
@@ -68,7 +68,7 @@ func httpRuleURL(rule *annotations.HttpRule) (string, error) {
 	case *annotations.HttpRule_Put:
 		return v.Put, nil
 	case *annotations.HttpRule_Custom:
-		return v.Custom.Path, nil
+		return v.Custom.GetPath(), nil
 	default:
 		return "", fmt.Errorf("http rule does not have an URL defined")
 	}
@@ -87,7 +87,7 @@ func httpRuleMethod(rule *annotations.HttpRule) (string, error) {
 	case *annotations.HttpRule_Put:
 		return http.MethodPut, nil
 	case *annotations.HttpRule_Custom:
-		return v.Custom.Kind, nil
+		return v.Custom.GetKind(), nil
 	default:
 		return "", fmt.Errorf("http rule does not have an URL defined")
 	}

internal/plugin/generate.go

@@ -16,16 +16,16 @@ import (
 func Generate(request *pluginpb.CodeGeneratorRequest) (*pluginpb.CodeGeneratorResponse, error) {
 	generate := make(map[string]struct{})
 	registry, err := protodesc.NewFiles(&descriptorpb.FileDescriptorSet{
-		File: request.ProtoFile,
+		File: request.GetProtoFile(),
 	})
 	if err != nil {
 		return nil, fmt.Errorf("create proto registry: %w", err)
 	}
-	for _, f := range request.FileToGenerate {
+	for _, f := range request.GetFileToGenerate() {
 		generate[f] = struct{}{}
 	}
 	packaged := make(map[protoreflect.FullName][]protoreflect.FileDescriptor)
-	for _, f := range request.FileToGenerate {
+	for _, f := range request.GetFileToGenerate() {
 		file, err := registry.FindFileByPath(f)
 		if err != nil {
 			return nil, fmt.Errorf("find file %s: %w", f, err)