feat(sggolicenses): add ignored dependencies #545
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds two go-licenses check functions to be able to pass repositories to be ignored. This might be need if the repositories have an open-source license in a format which is not recognised by the tool.
odsod
reviewed
Jun 12, 2024
| // Check for disallowed types of Go licenses in a specific directory. | ||
| // By default, Google's forbidden and restricted types are disallowed. | ||
| // Allows to ignore some dependencies by specifying their package path (ie "github.com/einride/sage"). | ||
| func CheckDirWithIgnored( |
There was a problem hiding this comment.
with this many helpers it might be better to inline it in the specific repos where it's used - the code here is just meant to be the "most common default" use case - not all possible use cases
There was a problem hiding this comment.
will close for now, the problem in the repo has been solved in another way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two go-licenses check functions to be able to pass repositories to be ignored. This might be needed if the repositories have an open-source license in a format which is not recognized by the tool.
See for example: ajstarks/svgo#73 and golang/freetype#94