Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use hasAnnotation for precise check in PolyTypeScanner #732

Merged
merged 4 commits into from
Apr 4, 2024

Conversation

Ao-senXiong
Copy link
Member

@Ao-senXiong Ao-senXiong commented Mar 31, 2024

This is related to Ontology as it use the value to represent poly type qualifier.
opprop/ontology#130

@Ao-senXiong Ao-senXiong changed the title Use hasExplicitAnnotation for precise check in PolyTypeScanner Use hasAnnotation for precise check in PolyTypeScanner Apr 1, 2024
@wmdietl
Copy link
Member

wmdietl commented Apr 1, 2024

Note that the plume_lib CI test currently fails, for the same reason as opprop#259
It seems related to the upgrade to Gradle 8.7 together with the CF gradle plugin being out of date.
I don't want to do the work-around from opprop#259, but haven't found anything better yet. Can you take a look?

@Ao-senXiong
Copy link
Member Author

Note that the plume_lib CI test currently fails, for the same reason as opprop#259 It seems related to the upgrade to Gradle 8.7 together with the CF gradle plugin being out of date. I don't want to do the work-around from opprop#259, but haven't found anything better yet. Can you take a look?

Sure, looks like all problem are the same. Let me take a look.

@Ao-senXiong
Copy link
Member Author

Note that the plume_lib CI test currently fails, for the same reason as opprop#259 It seems related to the upgrade to Gradle 8.7 together with the CF gradle plugin being out of date. I don't want to do the work-around from opprop#259, but haven't found anything better yet. Can you take a look?

@wmdietl It looks like the gradle version 8.7 is incompatible with CF plugin. The most simple approach is to downgrade to 8.6.
image

@wmdietl
Copy link
Member

wmdietl commented Apr 1, 2024

Downgrading sounds good. Could you please do this for the affected eisop-plume-lib projects?

But before that, we should improve the CI for the eisp-plume-lib projects. E.g. eisop-plume-lib/bcel-util#81 was automatically merged b/c CI was green. The build configuration contains the checkerframework-gradle-plugin, but it doesn't seem to run during CI. Or why is CI green there?

Can you first make a PR that improves CI, which will fail, then a PR that also downgrades gradle only. Then we first merge the downgrade and then the CI improvements.
Thanks!

@Ao-senXiong
Copy link
Member Author

Looks like the agent is time out again for non JUnit test

@wmdietl wmdietl changed the title Use hasAnnotation for precise check in PolyTypeScanner Use hasAnnotation for precise check in PolyTypeScanner Apr 3, 2024
@wmdietl wmdietl merged commit 8137698 into eisop:master Apr 4, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants