Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cfg #30

Closed
wants to merge 7 commits into from
Closed

Cfg #30

wants to merge 7 commits into from

Conversation

boyingl
Copy link
Contributor

@boyingl boyingl commented Jul 4, 2017

No description provided.

@wmdietl
Copy link
Member

wmdietl commented Jul 4, 2017

This looks identical to #29 . Can one of them be closed?

@CharlesZ-Chen
Copy link
Collaborator

#29 is created against our master branch, but this PR is not a mature feature that ready to be merged into master. So I told Ashley to create a new PR against to her own ashley-master branch on our repo. Will close #29 .

@CharlesZ-Chen CharlesZ-Chen mentioned this pull request Jul 4, 2017
@CharlesZ-Chen
Copy link
Collaborator

CharlesZ-Chen commented Jul 6, 2017

As I discussed on Tuesday in person with Ashley, we will make some change in Checker-Framework to let it output the dot file as string rather than write into files. Then we will invoke CFG mode in a different way in our server. That means most of the content of this PR will be updated later on.

At the moment, I will just leave this PR open, and wait Ashley to push more updates of our new way, then will start PR review again.

@wmdietl
Copy link
Member

wmdietl commented Apr 14, 2020

Opened #40 to implement this properly.

@wmdietl wmdietl closed this Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants