Updated to python3, java11 #48
Conversation
padenaa
commented
Nov 22, 2022
padenaa
commented
- removed instances of xbootclasspath:p since it's no longer supported
- printed java backend output to terminal for debuggability
- revised python libraries in the bottle server to the python3 versions
- java 17 still doesn't work even with the flags from the checker manual
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
shell-scripts/run-checker.sh
Outdated
| @@ -22,6 +22,6 @@ fi | |||
| CF=$2 | |||
| IS_RISE4FUN=$3 | |||
|
|
|||
| cat <<ENDEND | $JAVA_HOME/bin/java -Xmx2500M -Xbootclasspath/p:$CF/checker/dist/javac.jar -ea -ea:com.sun.tools... -cp $CF/checker/dist/checker.jar:../CheckerPrinter/bin:../CheckerPrinter/javax.json-1.0.jar:$JAVA_HOME/lib/tools.jar checkerprinter.InMemory $CF $IS_RISE4FUN | |||
| cat <<ENDEND | $JAVA_HOME/bin/java -Xmx2500M -Xbootclasspath/a:$CF/checker/dist/javac.jar -ea -ea:com.sun.tools... -cp $CF/checker/dist/checker.jar:../CheckerPrinter/bin:../CheckerPrinter/javax.json-1.0.jar:$JAVA_HOME/lib/tools.jar checkerprinter.InMemory $CF $IS_RISE4FUN | |||
There was a problem hiding this comment.
💬 5 similar findings have been found in this PR
SC2086: Double quote to prevent globbing and word splitting.
🔎 Expand here to view all instances of this finding
ℹ️ Learn about @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
…rver into update_python_java
| @@ -22,6 +22,6 @@ fi | |||
| CF=$2 | |||
| IS_RISE4FUN=$3 | |||
|
|
|||
| cat <<ENDEND | $JAVA_HOME/bin/java -Xmx2500M -Xbootclasspath/p:$CF/checker/dist/javac.jar -ea -ea:com.sun.tools... -cp $CF/checker/dist/checker.jar:../CheckerPrinter/bin:../CheckerPrinter/javax.json-1.0.jar:$JAVA_HOME/lib/tools.jar checkerprinter.InMemory $CF $IS_RISE4FUN | |||
| cat <<ENDEND | $JAVA_HOME/bin/java -Xmx2500M -ea -ea:com.sun.tools... -cp $CF/checker/dist/checker.jar:../CheckerPrinter/bin:../CheckerPrinter/javax.json-1.0.jar:$CF/checker/dist/javac.jar checkerprinter.InMemory $CF $IS_RISE4FUN | |||
There was a problem hiding this comment.
💬 4 similar findings have been found in this PR
SC2086: Double quote to prevent globbing and word splitting.
🔎 Expand here to view all instances of this finding
| File Path | Line Number |
|---|---|
| shell-scripts/run-checker.sh | 25 |
| shell-scripts/run-checker.sh | 25 |
| shell-scripts/run-checker.sh | 25 |
| shell-scripts/run-checker.sh | 25 |
Visit the Lift Web Console to find more details in your report.
ℹ️ Learn about @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
