Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add pl$repeat_() #108

Merged
merged 4 commits into from
Feb 16, 2025
Merged

feat: Add pl$repeat_() #108

merged 4 commits into from
Feb 16, 2025

Conversation

etiennebacher
Copy link
Contributor

repeat is a keyword, hence the name repeat_().

Bunch of irrelevant changes due to autoformatting in expr-expr.R, you can ignore this file.

@eitsupi
Copy link
Owner

eitsupi commented Feb 16, 2025

Thanks!
I wonder if we can define pl$rep() as an alias.

@etiennebacher
Copy link
Contributor Author

I dont really see the point, I think it would be confusing to have "rep", "repeat_", and "repeat_by" in the code suggestions

eitsupi
eitsupi approved these changes Feb 16, 2025
View reviewed changes
Copy link
Owner

@eitsupi eitsupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, let's merge this for now.

@eitsupi eitsupi merged commit 0f3e0d0 into eitsupi:main Feb 16, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eitsupi eitsupi eitsupi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@etiennebacher @eitsupi