Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support WASM/webR builds #50

Merged
merged 18 commits into from
Jan 11, 2025
Merged

fix: support WASM/webR builds #50

merged 18 commits into from
Jan 11, 2025

Conversation

eitsupi
Copy link
Owner

@eitsupi eitsupi commented Dec 30, 2024

No description provided.

@eitsupi eitsupi changed the title fix: fix some WASM/webR build errors fix: fix WASM/webR build Dec 30, 2024
@eitsupi eitsupi changed the title fix: fix WASM/webR build fix: support WASM/webR builds Dec 30, 2024
@eitsupi eitsupi marked this pull request as ready for review December 30, 2024 03:26
@eitsupi eitsupi marked this pull request as draft December 30, 2024 03:33
@eitsupi
Copy link
Owner Author

eitsupi commented Dec 30, 2024

Builds successfully, but savvy-cli update does not work. (yutannihilation/savvy#333)

@eitsupi

This comment was marked as outdated.

@eitsupi
Copy link
Owner Author

eitsupi commented Dec 31, 2024

It works now.

> install.packages("rlang")
Downloading webR package: rlang
> install.packages("neopolars", repos = "https://eitsupi.r-universe.dev")
Downloading webR package: neopolars
> library(neopolars)
> as_polars_df(mtcars)$select("cyl", "am")
shape: (32, 2)
┌─────┬─────┐
│ cylam  │
│ ------ │
│ f64f64 │
╞═════╪═════╡
│ 6.01.0 │
│ 6.01.0 │
│ 4.01.0 │
│ 6.00.0 │
│ 8.00.0 │
│ …   ┆ …   │
│ 4.01.0 │
│ 8.01.0 │
│ 6.01.0 │
│ 8.01.0 │
│ 4.01.0 │
└─────┴─────┘

@eitsupi eitsupi force-pushed the wasm branch 2 times, most recently from 283ceb6 to b57e2b0 Compare January 5, 2025 10:28
@eitsupi eitsupi marked this pull request as ready for review January 11, 2025 14:20
@eitsupi eitsupi marked this pull request as draft January 11, 2025 15:14
…' into wasm" to try to fix wasm build error

This reverts commit 95860cc, reversing
changes made to c1a262c.
@yutannihilation
Copy link

I'm suspecting the cc crate, which was updated within a day. I'm seeing a similar error.

https://github.com/rust-lang/cc-rs/releases/tag/cc-v1.2.8

@eitsupi
Copy link
Owner Author

eitsupi commented Jan 11, 2025

Thank you for your comment.
Based on the comparison of the latest few commits, it looks like something pulled in by the cargo update in a4c2e28 is the cause, so your guess seems to be correct.

@eitsupi eitsupi marked this pull request as ready for review January 11, 2025 15:53
@eitsupi eitsupi merged commit b900d63 into main Jan 11, 2025
1 check passed
@eitsupi eitsupi deleted the wasm branch January 11, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants