Updated flake version to fix incorrect flake error E231 #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like this caused a new type of error to appear:
|
|
Fixed. |
|
Looks good to me. |
|
@fpjentzsch @iksnagreb Are you fine with too? Then I'd merge. |
|
Looks good. Could you maybe propose this as PR to xilinx/finn as well? I do not want to adhere to two different linting/style rule sets depending on where I PR to... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says, flake incorrectly flags fstrings such as:
with an E231 error which requires you to insert whitespaces around : , ; etc.
This only occurs in Python 3.12 and below flake 6.1.0 apparently. FINN currently is on Python 3.10 but we still might want to fix this beforehand or if anyone uses a 3.12 dev environment.