Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Deps] Update qonnx to track https://github.com/iksnagreb/qonnx #9

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from

Conversation

@fpjentzsch
Copy link

I get the following for a Transformer build that previously worked on iksnagreb/qonnx/transformer (+ 2 unrelated commits cherry-picked from main):

Traceback (most recent call last):
1128 File "/usr/lib/python3.10/multiprocessing/pool.py", line 125, in worker
1129 result = (True, func(*args, **kwds))
1130 File "/usr/lib/python3.10/multiprocessing/pool.py", line 48, in mapstar
1131 return list(map(*args))
1132 File "/dev/shm/finn/src/finn/transformation/fpgadataflow/prepare_cppsim.py", line 84, in prepareCppSim_node
1133 _codegen_single_node(node, self.model)
1134 File "/dev/shm/finn/src/finn/transformation/fpgadataflow/prepare_cppsim.py", line 57, in _codegen_single_node
1135 inst.code_generation_cppsim(model)
1136 File "/dev/shm/finn/src/finn/custom_op/fpgadataflow/hlsbackend.py", line 203, in code_generation_cppsim
1137 self.defines("cppsim")
1138 File "/dev/shm/finn/src/finn/custom_op/fpgadataflow/hls/elementwise_binary_hls.py", line 233, in defines
1139 f"using OutType = {self.out_dtype.get_hls_datatype_str()};",
1140 File "/dev/shm/finn/deps/qonnx/src/qonnx/core/datatype.py", line 365, in get_hls_datatype_str
1141 raise Exception("Undefined for ScaledIntType")
1142Exception: Undefined for ScaledIntType

@iksnagreb
Copy link
Author

Hm, as the ScaledIntType issue seems to be fixed on some of the range analysis related branches and I will need this stuff for ongoing/upcoming research anyway, I am seriously considering to merge the current state of range analysis into our qonnx dependency. The experimental analysis pass and the (not yet fully integrated) reworked streamlining should not interfere with any of our build flows (these are just optional extras for now), but somewhere among the ~130 commits must be the bugfix for whatever this ScaledIntType issue is... What do you think?

@fpjentzsch
Copy link

fpjentzsch commented Jan 22, 2025

I still get the ScaledIntType error if I switch to this QONNX commit: iksnagreb/qonnx@31880be

This is the old commit where synthesis and verification still passes: iksnagreb/qonnx@1888fab

Seems to fix some issues related to scaled-int types and brings in
infrastructure required by ongoing/upcoming research.
@iksnagreb iksnagreb marked this pull request as ready for review January 28, 2025 20:13
@iksnagreb iksnagreb self-assigned this Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants