Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linux build dependency of glibc #2389

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Conversation

stevejgordon
Copy link
Contributor

Fixes #2383

Update Linux builds of the Rust profiler to use zigbuild so that we can pin to an older version of GLIBC to avoid crashing on older distributions. This PR also removes some redundant files from the Linux profiler zip and updates the docs.

@stevejgordon stevejgordon force-pushed the fix-linux-profiler-build branch 4 times, most recently from ceeefef to 7fb9f9f Compare July 2, 2024 14:41
Mpdreamz
Mpdreamz previously approved these changes Jul 2, 2024
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the docs and contributing updates!

Also neatly done creating an isolated cargo build task 👍

@stevejgordon
Copy link
Contributor Author

Thanks, @Mpdreamz. The MongoDb license slipped through into my commit, plus I fixed a typo. I am ready for a final review and will merge and try a release.

Mpdreamz
Mpdreamz previously approved these changes Jul 3, 2024
@stevejgordon stevejgordon merged commit d99347d into main Jul 3, 2024
20 checks passed
@stevejgordon stevejgordon deleted the fix-linux-profiler-build branch July 3, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants