Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix span linking for Azure ServiceBus #2474

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix span linking for Azure ServiceBus #2474

wants to merge 1 commit into from
+6 −2

Commits on Nov 4, 2024

  1. Fix span linking for Azure ServiceBus 

    Align span ID with activity's span ID in ServiceBus listener

The code changes in the `AzureMessagingServiceBusDiagnosticListener.cs`
file within the `Elastic.Apm.Azure.ServiceBus` namespace involve
modifications to how spans are started for message actions. Specifically,
the `StartSpanInternal` method now includes an explicit `id` parameter
set to `activity.SpanId.ToString()`. This change ensures that the span ID
matches the activity's span ID, which is crucial for correctly linking
the consuming span to the producer. This adjustment is necessary because
the Azure SDK automatically attaches the `diagnostic-id` and `traceparent`
to the message, and proper span linking on the receiver end depends on
this alignment.
    @stevejgordon
    stevejgordon committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    f4b3e4e View commit details
    Browse the repository at this point in the history