tests: use a known test phone for SNS v3 tests (#3632)

elastic · Sep 26, 2023 · c888b4c · c888b4c
1 parent 3a26c89
commit c888b4c
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/test/instrumentation/modules/@aws-sdk/fixtures/use-client-sns.js b/test/instrumentation/modules/@aws-sdk/fixtures/use-client-sns.js
@@ -36,7 +36,7 @@
 
 const TEST_IGNORE_TOPIC = 'topic-to-ignore';
 const TEST_IGNORE_TARGET = 'target-to-ignore';
-const TEST_IGNORE_PHONE = '6666666';
+const TEST_IGNORE_PHONE = '0101';
 
 const apm = require('../../../../..').start({
   serviceName: 'use-client-sns',
@@ -110,7 +110,7 @@ async function useClientSNS(snsClient, topicName) {
   // https://docs.aws.amazon.com/AWSJavaScriptSDK/v3/latest/client/sns/command/PublishCommand/
   command = new PublishCommand({
     Message: 'message to be sent',
-    PhoneNumber: '+34555555555',
+    PhoneNumber: '+15555550100',
   });
   data = await snsClient.send(command);
   assert(
@@ -177,7 +177,7 @@ async function useClientSNS(snsClient, topicName) {
 
   command = new PublishCommand({
     Message: 'message to be sent',
-    PhoneNumber: `+34${TEST_IGNORE_PHONE}`,
+    PhoneNumber: `+1555555${TEST_IGNORE_PHONE}`,
   });
   data = await snsClient.send(command);
   assert(
@@ -190,7 +190,7 @@ async function useClientSNS(snsClient, topicName) {
     Message: 'message to be sent',
     TopicArn: topicArn,
     TargetArn: topicArn,
-    PhoneNumber: `+345555555`,
+    PhoneNumber: '+15555550100',
   });
   data = await snsClient.send(command);
   assert(

diff --git a/test/instrumentation/modules/@aws-sdk/fixtures/use-client-sns.mjs b/test/instrumentation/modules/@aws-sdk/fixtures/use-client-sns.mjs
@@ -23,7 +23,7 @@ import assert from 'assert';
 async function useClientSNS(snsClient) {
   const command = new PublishCommand({
     Message: 'message to be sent',
-    PhoneNumber: '+34555555555',
+    PhoneNumber: '+15555550100',
   });
   const data = await snsClient.send(command);
   assert(

diff --git a/test/instrumentation/modules/aws-sdk/sns.test.js b/test/instrumentation/modules/aws-sdk/sns.test.js
@@ -103,10 +103,10 @@ tape.test('AWS SNS: Unit Test Functions', function (test) {
         params: {
           Message:
             'this is my test, there are many like it but this one is mine',
-          PhoneNumber: '1-555-555-5555',
+          PhoneNumber: '+15555550100',
         },
       }),
-      '1-555-555-5555',
+      '+15555550100',
     );
 
     t.end();
@@ -170,7 +170,7 @@ tape.test('AWS SNS: Unit Test Functions', function (test) {
         params: {
           Message: 'work test',
           Subject: 'Admin',
-          PhoneNumber: '15037299028',
+          PhoneNumber: '+15555550100',
         },
       }),
       '<PHONE_NUMBER>',
@@ -189,7 +189,7 @@ tape.test('AWS SNS: Unit Test Functions', function (test) {
         params: {
           Message: 'work test',
           Subject: 'Admin',
-          PhoneNumber: '15555555555',
+          PhoneNumber: '+15555550100',
         },
       }),
       'SNS PUBLISH to <PHONE_NUMBER>',