chore: add min version in TAV matrix #3531
Conversation
… testing for contextManager=patch
github-actions
bot
added
the
agent-nodejs
|
The matrix workflow shows the values of each dimension for each run. In our case dimensions are
When looking at the workflow, the list of runs differs a little bit of what we are used to |
this did not run anything since min node version set is higher than 10 |
this fails because the package name is not in listed in |
.ci/tav.json
Outdated
| "@koa/router,koa-router", | ||
| "handlebars,pug", | ||
| "bluebird,got" | ||
| {"name": "@apollo/server", "minVersion": 18 }, |
There was a problem hiding this comment.
Note for reviewer: to run less tests we add minVersion to 18. This shall be updated with the proper versions if the PR is okay to merge
|
Turns out you can pass a single array (so it's a 1 dimension matrix). Now the list of the tasks looks nicer showing.the module name and the node version separated by a space.
|
Now it fails and logs the name of the wrong package |
.ci/tav.json
Outdated
| {"name": "ws", "minVersion": 8 }, | ||
| {"name": "@koa/router,koa-router", "minVersion": 8 }, | ||
| {"name": "handlebars,pug", "minVersion": 8 }, | ||
| {"name": "bluebird,got", "minVersion": 8 } |
There was a problem hiding this comment.
Hrm, I guess with all these minVersion: 8s, it means there won't be a large reduction in the number of jobs. Still probably worth keeping.
(Not part of this PR, but I wonder if we could consider dropping testing for versions of these packages that are, say, older than 2y and not of the latest major version. That might enable raising the minVersion here.)
There was a problem hiding this comment.
Maybe we can leverage the multiple package option we have, here we are testing 2 packages in the same job
{"name": "bluebird,got", "minVersion": 8 }
This is actually what I want to do for @aws-sdk/client-* to test all of them at once for each version. There might be other groups we could make perhaps @opentelemetry/* or mysql? Of course some test review is needed to see compatibility. Also I think the runTestFixtures util introduced in the ESM support PR would come handy
we could consider dropping testing for versions of these packages that are, say, older than 2y
I agree and also I think it could be something to motivate users to update
Co-authored-by: Trent Mick <[email protected]>
Co-authored-by: Trent Mick <[email protected]>
Update the format of `tav.json` file and changed the workflow actions to have more control on how to generate the job matrix for testing. --------- Co-authored-by: Trent Mick <[email protected]>
Tweak
tav.jsonfile andtav.ymlandtav-command.ymlactions so we can specify which is the min version where the module should be tested. The matrix generated contains only one row where each element containsmodule node_versionin a single place.set to draft to test it and discuss with the team
Checklist