Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: drop "timer" option to startTransaction/startSpan #3537

Merged
merged 2 commits into from
Aug 2, 2023

Conversation

trentm
Copy link
Member

@trentm trentm commented Aug 1, 2023

Closes: #2990

@trentm trentm requested a review from david-luna August 1, 2023 23:24
@trentm trentm self-assigned this Aug 1, 2023
@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Aug 1, 2023
Copy link
Member

@david-luna david-luna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we warn about the agent ignoring/removing the option so app devs can drop it in their apps config?

@trentm
Copy link
Member Author

trentm commented Aug 2, 2023

can drop it in their apps config?

I might be misunderstanding you, but this isn't an app config thing. This could only impact a user if they were doing:

apm.startSpan('my-span-name', {timer: <some custom Timer object>})

where that timer option was never documented.

@david-luna
Copy link
Member

Thanks for the clarification :)

@trentm trentm merged commit 6f2f035 into dev/4.x Aug 2, 2023
2 of 11 checks passed
@trentm trentm deleted the trentm/4x-drop-timer-startSpan branch August 2, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-nodejs Make available for APM Agents project planning.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants