Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore!: drop support for obsolete "hapi" package #3541

Merged
merged 1 commit into from
Aug 3, 2023
Merged

chore!: drop support for obsolete "hapi" package #3541

merged 1 commit into from
Aug 3, 2023

Conversation

trentm
Copy link
Member

@trentm trentm commented Aug 2, 2023

Closes: #2691

@trentm trentm requested a review from david-luna August 2, 2023 19:40
@trentm trentm self-assigned this Aug 2, 2023
@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Aug 2, 2023
trentm
trentm commented Aug 2, 2023
View reviewed changes
Copy link
Member Author

@trentm trentm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test tav @hapi/hapi

@trentm
Copy link
Member Author

trentm commented Aug 2, 2023

Here is a local tav test run with node v14, FWIW:

% TAV=@hapi/hapi ./node_modules/.bin/tav -q
-- required packages ["@hapi/[email protected]"]
-- installing ["@hapi/[email protected]"]
-- running test "node test/instrumentation/modules/hapi/hapi.test.js" with @hapi/hapi
-- running test "node test/instrumentation/modules/hapi/set-framework.test.js" with @hapi/hapi
-- required packages ["@hapi/[email protected]"]
-- installing ["@hapi/[email protected]"]
-- running test "node test/instrumentation/modules/hapi/hapi.test.js" with @hapi/hapi
-- running test "node test/instrumentation/modules/hapi/set-framework.test.js" with @hapi/hapi
-- required packages ["@hapi/[email protected]"]
-- installing ["@hapi/[email protected]"]
-- running test "node test/instrumentation/modules/hapi/hapi.test.js" with @hapi/hapi
-- running test "node test/instrumentation/modules/hapi/set-framework.test.js" with @hapi/hapi
-- required packages ["@hapi/[email protected]"]
-- installing ["@hapi/[email protected]"]
-- running test "node test/instrumentation/modules/hapi/hapi.test.js" with @hapi/hapi
-- running test "node test/instrumentation/modules/hapi/set-framework.test.js" with @hapi/hapi
-- required packages ["@hapi/[email protected]"]
-- installing ["@hapi/[email protected]"]
-- running test "node test/instrumentation/modules/hapi/hapi.test.js" with @hapi/hapi
-- running test "node test/instrumentation/modules/hapi/set-framework.test.js" with @hapi/hapi
-- required packages ["@hapi/[email protected]"]
-- installing ["@hapi/[email protected]"]
-- running test "node test/instrumentation/modules/hapi/hapi.test.js" with @hapi/hapi
-- running test "node test/instrumentation/modules/hapi/set-framework.test.js" with @hapi/hapi
-- required packages ["@hapi/[email protected]"]
-- installing ["@hapi/[email protected]"]
-- running test "node test/instrumentation/modules/hapi/hapi.test.js" with @hapi/hapi
-- running test "node test/instrumentation/modules/hapi/set-framework.test.js" with @hapi/hapi
-- required packages ["@hapi/[email protected]"]
-- installing ["@hapi/[email protected]"]
-- running test "node test/instrumentation/modules/hapi/hapi.test.js" with @hapi/hapi
-- running test "node test/instrumentation/modules/hapi/set-framework.test.js" with @hapi/hapi
-- required packages ["@hapi/[email protected]"]
-- installing ["@hapi/[email protected]"]
-- running test "node test/instrumentation/modules/hapi/hapi.test.js" with @hapi/hapi
-- running test "node test/instrumentation/modules/hapi/set-framework.test.js" with @hapi/hapi
-- required packages ["@hapi/[email protected]"]
-- installing ["@hapi/[email protected]"]
-- running test "node test/instrumentation/modules/hapi/hapi.test.js" with @hapi/hapi
-- running test "node test/instrumentation/modules/hapi/set-framework.test.js" with @hapi/hapi
-- required packages ["@hapi/[email protected]"]
-- installing ["@hapi/[email protected]"]
-- running test "node test/instrumentation/modules/hapi/hapi.test.js" with @hapi/hapi
-- running test "node test/instrumentation/modules/hapi/set-framework.test.js" with @hapi/hapi
-- required packages ["@hapi/[email protected]"]
-- installing ["@hapi/[email protected]"]
-- running test "node test/instrumentation/modules/hapi/hapi.test.js" with @hapi/hapi
-- running test "node test/instrumentation/modules/hapi/set-framework.test.js" with @hapi/hapi
-- required packages ["@hapi/[email protected]"]
-- installing ["@hapi/[email protected]"]
-- running test "node test/instrumentation/modules/hapi/hapi.test.js" with @hapi/hapi
-- running test "node test/instrumentation/modules/hapi/set-framework.test.js" with @hapi/hapi
-- required packages ["@hapi/[email protected]"]
-- installing ["@hapi/[email protected]"]
-- running test "node test/instrumentation/modules/hapi/hapi.test.js" with @hapi/hapi
-- running test "node test/instrumentation/modules/hapi/set-framework.test.js" with @hapi/hapi
-- required packages ["@hapi/[email protected]"]
-- installing ["@hapi/[email protected]"]
-- running test "node test/instrumentation/modules/hapi/hapi.test.js" with @hapi/hapi
-- running test "node test/instrumentation/modules/hapi/set-framework.test.js" with @hapi/hapi
-- required packages ["@hapi/[email protected]"]
-- installing ["@hapi/[email protected]"]
-- running test "node test/instrumentation/modules/hapi/hapi.test.js" with @hapi/hapi
-- running test "node test/instrumentation/modules/hapi/set-framework.test.js" with @hapi/hapi
-- required packages ["@hapi/[email protected]"]
-- installing ["@hapi/[email protected]"]
-- running test "node test/instrumentation/modules/hapi/hapi.test.js" with @hapi/hapi
-- running test "node test/instrumentation/modules/hapi/set-framework.test.js" with @hapi/hapi
-- required packages ["@hapi/[email protected]"]
-- installing ["@hapi/[email protected]"]
-- running test "node test/instrumentation/modules/hapi/hapi.test.js" with @hapi/hapi
-- running test "node test/instrumentation/modules/hapi/set-framework.test.js" with @hapi/hapi
-- required packages ["@hapi/[email protected]"]
-- installing ["@hapi/[email protected]"]
-- running test "node test/instrumentation/modules/hapi/hapi.test.js" with @hapi/hapi
-- running test "node test/instrumentation/modules/hapi/set-framework.test.js" with @hapi/hapi
-- required packages ["@hapi/[email protected]"]
-- installing ["@hapi/[email protected]"]
-- running test "node test/instrumentation/modules/hapi/hapi.test.js" with @hapi/hapi
-- running test "node test/instrumentation/modules/hapi/set-framework.test.js" with @hapi/hapi
-- required packages ["@hapi/[email protected]"]
-- installing ["@hapi/[email protected]"]
-- running test "node test/instrumentation/modules/hapi/hapi.test.js" with @hapi/hapi
-- running test "node test/instrumentation/modules/hapi/set-framework.test.js" with @hapi/hapi
-- required packages ["@hapi/[email protected]"]
-- installing ["@hapi/[email protected]"]
-- running test "node test/instrumentation/modules/hapi/hapi.test.js" with @hapi/hapi
-- running test "node test/instrumentation/modules/hapi/set-framework.test.js" with @hapi/hapi
-- required packages ["@hapi/[email protected]"]
-- installing ["@hapi/[email protected]"]
-- running test "node test/instrumentation/modules/hapi/hapi.test.js" with @hapi/hapi
-- running test "node test/instrumentation/modules/hapi/set-framework.test.js" with @hapi/hapi
-- required packages ["@hapi/[email protected]"]
-- installing ["@hapi/[email protected]"]
-- running test "node test/instrumentation/modules/hapi/hapi.test.js" with @hapi/hapi
-- running test "node test/instrumentation/modules/hapi/set-framework.test.js" with @hapi/hapi
-- required packages ["@hapi/[email protected]"]
-- installing ["@hapi/[email protected]"]
-- running test "node test/instrumentation/modules/hapi/hapi.test.js" with @hapi/hapi
-- running test "node test/instrumentation/modules/hapi/set-framework.test.js" with @hapi/hapi
-- required packages ["@hapi/[email protected]"]
-- installing ["@hapi/[email protected]"]
-- running test "node test/instrumentation/modules/hapi/hapi.test.js" with @hapi/hapi
-- running test "node test/instrumentation/modules/hapi/set-framework.test.js" with @hapi/hapi
-- required packages ["@hapi/[email protected]"]
-- installing ["@hapi/[email protected]"]
-- running test "node test/instrumentation/modules/hapi/hapi.test.js" with @hapi/hapi
-- running test "node test/instrumentation/modules/hapi/set-framework.test.js" with @hapi/hapi
-- required packages ["@hapi/[email protected]"]
-- installing ["@hapi/[email protected]"]
-- running test "node test/instrumentation/modules/hapi/hapi.test.js" with @hapi/hapi
-- running test "node test/instrumentation/modules/hapi/set-framework.test.js" with @hapi/hapi
-- required packages ["@hapi/[email protected]"]
-- installing ["@hapi/[email protected]"]
-- running test "node test/instrumentation/modules/hapi/hapi.test.js" with @hapi/hapi
-- running test "node test/instrumentation/modules/hapi/set-framework.test.js" with @hapi/hapi
-- required packages ["@hapi/[email protected]"]
-- installing ["@hapi/[email protected]"]
-- running test "node test/instrumentation/modules/hapi/hapi.test.js" with @hapi/hapi
-- running test "node test/instrumentation/modules/hapi/set-framework.test.js" with @hapi/hapi
-- required packages ["@hapi/[email protected]"]
-- installing ["@hapi/[email protected]"]
-- running test "node test/instrumentation/modules/hapi/hapi.test.js" with @hapi/hapi
-- running test "node test/instrumentation/modules/hapi/set-framework.test.js" with @hapi/hapi
-- required packages ["@hapi/[email protected]"]
-- installing ["@hapi/[email protected]"]
-- running test "node test/instrumentation/modules/hapi/hapi.test.js" with @hapi/hapi
-- running test "node test/instrumentation/modules/hapi/set-framework.test.js" with @hapi/hapi
-- required packages ["@hapi/[email protected]"]
-- installing ["@hapi/[email protected]"]
-- running test "node test/instrumentation/modules/hapi/hapi.test.js" with @hapi/hapi
-- running test "node test/instrumentation/modules/hapi/set-framework.test.js" with @hapi/hapi
-- required packages ["@hapi/[email protected]"]
-- installing ["@hapi/[email protected]"]
-- running test "node test/instrumentation/modules/hapi/hapi.test.js" with @hapi/hapi
-- running test "node test/instrumentation/modules/hapi/set-framework.test.js" with @hapi/hapi
-- required packages ["@hapi/[email protected]"]
-- installing ["@hapi/[email protected]"]
-- running test "node test/instrumentation/modules/hapi/hapi.test.js" with @hapi/hapi
-- running test "node test/instrumentation/modules/hapi/set-framework.test.js" with @hapi/hapi
-- required packages ["@hapi/[email protected]"]
-- installing ["@hapi/[email protected]"]
-- running test "node test/instrumentation/modules/hapi/hapi.test.js" with @hapi/hapi
-- running test "node test/instrumentation/modules/hapi/set-framework.test.js" with @hapi/hapi
-- required packages ["@hapi/[email protected]"]
-- installing ["@hapi/[email protected]"]
-- running test "node test/instrumentation/modules/hapi/hapi.test.js" with @hapi/hapi
-- running test "node test/instrumentation/modules/hapi/set-framework.test.js" with @hapi/hapi
-- required packages ["@hapi/[email protected]"]
-- installing ["@hapi/[email protected]"]
-- running test "node test/instrumentation/modules/hapi/hapi.test.js" with @hapi/hapi
-- running test "node test/instrumentation/modules/hapi/set-framework.test.js" with @hapi/hapi
-- ok

@trentm trentm merged commit 3670166 into dev/4.x Aug 3, 2023
21 checks passed
@trentm trentm deleted the trentm/4x-drop-old-hapi branch August 3, 2023 16:49
@trentm trentm mentioned this pull request Aug 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-luna david-luna david-luna approved these changes

Assignees

@trentm trentm

Labels
agent-nodejs Make available for APM Agents project planning.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trentm @david-luna