chore!: drop trans.subtype and trans.action #3557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This impacts using those properties directly on a Transaction, some calling forms for apm.startTransaction(...), and transaction.setType(...). These properties were deprecated in v3.23.0. Closes: #2357
github-actions
bot
added
the
agent-nodejs
david-luna
approved these changes
Aug 14, 2023
david-luna
approved these changes
Aug 14, 2023
|
question: #2357 states the fields |
Yes. For example, here is "subtype" in the span intake schema: apm-agent-nodejs/test/integration/api-schema/apm-server-schema/span.json Lines 832 to 837 in 3a4725e |
… a name arg This had already been the case before these changes.
trentm
added a commit
that referenced
this pull request
Sep 1, 2023
feat!: the start of v4.x Significant and breaking changes: - Min supported Node.js is now 14.5.0 (up from 8.6). - Drop support for the obsolete "patch" context manager, i.e. the `contextManager: "patch"` config option. This was a limited async context management that predated the preferred `AsyncLocalStorage` core Node.js mechanism for context tracking. (#3529) - Config vars: - Remove `logUncaughtExceptions` config option, if the agent's `uncaughtException` handler is active it now *always* logs the error to the console. (#2412) - Remove `filterHttpHeaders` config option, see `sanitizeFieldNames` instead. (#3332) - Remove long deprecate `ELASTIC_APM_KUBERNETES_*` envvars, use `KUBERNETES_*` instead. (#2661) - The `useElasticTraceparentHeader` config option now defaults to `false`. This means the `elastic-apm-traceparent` HTTP header is now no longer sent by default. (#3555) - Drop erroneous `ELASTIC_SANITIZE_FIELD_NAMES` and `ELASTIC_IGNORE_MESSAGE_QUEUES` config envvars. - Instrumentations: - Drop instrumentation for old `hapi`, the current `@hapi/hapi` is still instrumented. (#2691) - APIs: - Ignore a `timer` option passed to `startTransaction()` and `startSpan()` APIs. (#2990) - Remove the deprecated `span.toString()` and `transaction.toString()` APIs. (#2348) - Change `apm.startTransaction()` API to return a noop transaction instead of null when the agent is not started. (#2429) - Remove `transaction.subtype` and `transaction.action` properties from the API. This also impacts <<apm-start-transaction>> and `transaction.setType(...)`, both of which now no longer accept `subtype` and `action` parameters. (#3557)
fpm-peter
pushed a commit
to fpm-git/apm-agent-nodejs
that referenced
this pull request
Aug 20, 2024
feat!: the start of v4.x Significant and breaking changes: - Min supported Node.js is now 14.5.0 (up from 8.6). - Drop support for the obsolete "patch" context manager, i.e. the `contextManager: "patch"` config option. This was a limited async context management that predated the preferred `AsyncLocalStorage` core Node.js mechanism for context tracking. (elastic#3529) - Config vars: - Remove `logUncaughtExceptions` config option, if the agent's `uncaughtException` handler is active it now *always* logs the error to the console. (elastic#2412) - Remove `filterHttpHeaders` config option, see `sanitizeFieldNames` instead. (elastic#3332) - Remove long deprecate `ELASTIC_APM_KUBERNETES_*` envvars, use `KUBERNETES_*` instead. (elastic#2661) - The `useElasticTraceparentHeader` config option now defaults to `false`. This means the `elastic-apm-traceparent` HTTP header is now no longer sent by default. (elastic#3555) - Drop erroneous `ELASTIC_SANITIZE_FIELD_NAMES` and `ELASTIC_IGNORE_MESSAGE_QUEUES` config envvars. - Instrumentations: - Drop instrumentation for old `hapi`, the current `@hapi/hapi` is still instrumented. (elastic#2691) - APIs: - Ignore a `timer` option passed to `startTransaction()` and `startSpan()` APIs. (elastic#2990) - Remove the deprecated `span.toString()` and `transaction.toString()` APIs. (elastic#2348) - Change `apm.startTransaction()` API to return a noop transaction instead of null when the agent is not started. (elastic#2429) - Remove `transaction.subtype` and `transaction.action` properties from the API. This also impacts <<apm-start-transaction>> and `transaction.setType(...)`, both of which now no longer accept `subtype` and `action` parameters. (elastic#3557)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This impacts using those properties directly on a Transaction,
some calling forms for apm.startTransaction(...), and
transaction.setType(...).
These properties were deprecated in v3.23.0.
Closes: #2357