chore: better logging for config state and transaction sampling #4291
Conversation
This adds a periodic (once per minute) dump of effective config changes from the default, once per minute at 'trace'-level. This also fixes an issue where a central-config update of `log_level` did not update the *child* logger on the APM client. Only the agent's own logger's level was updated. This adds trans.sampled to some debug logging output.
|
I need to work through the test errors. |
|
The v20 test failures are fixed by #4295 |
| // agent by setting trace-level logging and getting 1 minute of logs. | ||
| // (Sometimes getting logs from application *start* is no possible.) | ||
| setInterval(() => { | ||
| if (this.logger.isLevelEnabled('trace')) { |
There was a problem hiding this comment.
could the level be changed at runtime? If not I think we could setInterval within this block.
There was a problem hiding this comment.
Yes it can be changed at runtime via central config, and in the use case I needed this for that was the case.
I balked at integrating this change with central config handling.
However, I may do that for the main branch version of this change, because having a setInterval running all the time kinda sucks. On the other hand, having a setInterval (change in behaviour, however slight) that only turns on in "trace" made could mean more subtle bugs. It would be awful if there was a crash that only resulted from code that enabled when in "trace" mode. I'm talking generally.
makes sense to have record of the diif in config and also the sampled transactions. This is |
This adds a periodic (once per minute) dump of effective config changes
from the default, once per minute at 'trace'-level.
This also fixes an issue where a central-config update of
log_leveldid not update the child logger on the APM client. Only the agent's
own logger's level was updated.
This adds trans.sampled to some debug logging output.
@david-luna Note this is targeting 3.x. If this looks reasonable, I'll adapt the patch for "main" as well.