Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elastic APM v4.7.0 breaks versions of Faraday < 1.3.0 #1418

Closed
ryanwi opened this issue Sep 15, 2023 · 3 comments · Fixed by #1419
Closed

Elastic APM v4.7.0 breaks versions of Faraday < 1.3.0 #1418

ryanwi opened this issue Sep 15, 2023 · 3 comments · Fixed by #1419

Comments

@ryanwi
Copy link

ryanwi commented Sep 15, 2023

In an application with Faraday v0.17.4, experienced new errors after upgrading the Elastic APM gem from v4.6.0 to v4.7.0. Elastic APM is looking for a response_status on Faraday errors that does not exist in older versions of Faraday.

errors were:

undefined method `response_status' for #<Faraday::TimeoutError:0x00007f401377b2d0>
undefined method `response_status' for #<Faraday::SSLError:0x00007fbcac2e7960>
undefined method `response_status' for #<Faraday::ConnectionFailed:0x00007fae7dcd8420> 

Here is the change in v4.7.0: v4.6.0...v4.7.0#diff-4b5630a4907f497d4416de76c8dd5a162f4a525222dc3c11bdcef2182a9cdbcdR112

response_status was introduced to Faraday in this commit: lostisland/faraday@023cc41 and is only available in faraday versions >= 1.3.0

@estolfo
Copy link
Contributor

estolfo commented Sep 18, 2023

Thanks for reporting this and for the looking into the details @ryanwi

@estolfo
Copy link
Contributor

estolfo commented Sep 25, 2023

Hi @ryanwi I've opened a PR to fix this. If you have a chance to try it out, that'd be great. Thanks!

@ryanwi
Copy link
Author

ryanwi commented Oct 25, 2023

Thank you @estolfo !I haven't had a chance to test it, but will check it out when the Dependabot update comes through.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants