Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use response method on Faraday error for older versions of the library #1419

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Use response method on Faraday error for older versions of the library #1419

merged 1 commit into from
Oct 24, 2023

Conversation

estolfo
Copy link
Contributor

@estolfo estolfo commented Sep 25, 2023

Resolves #1418

@estolfo estolfo mentioned this pull request Sep 25, 2023
Closed
picandocodigo
picandocodigo approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@picandocodigo picandocodigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I reproduced the original error and this change fixes it 👍

@estolfo estolfo merged commit 7fd9ec2 into elastic:main Oct 24, 2023
58 checks passed
@picandocodigo picandocodigo mentioned this pull request Jan 9, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@picandocodigo picandocodigo picandocodigo approved these changes

Assignees
No one assigned
Labels
agent-ruby
Projects
APM-Agents (OLD)
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Elastic APM v4.7.0 breaks versions of Faraday < 1.3.0
2 participants
@estolfo @picandocodigo