Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updatecli: link to the original Pull Request #1424

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Conversation

v1v
Copy link
Member

@v1v v1v commented Nov 7, 2023

What

Add the original Pull Request that contains the changes in the specs to be in the description of the Pull Request created with the updatecli automation. This will help with track what APM Agents use it.

Test

Given the updatecli and gh cli

When running

$ GIT_USER=foo \
GIT_EMAIL=1 \
GITHUB_TOKEN=*** \
updatecli apply --config .ci/updatecli.d/update-specs.yml --push=false --debug

Then

...
✔ content: found from file "https://github.com/elastic/apm-data/commit/main.patch":
From 5d596b8bb0cbf31aac8ea65e611a8d5d7d5b482d 
...
----
https://github.com/elastic/apm-data/pull/178
----
...

@v1v v1v added the automation label Nov 7, 2023
@v1v v1v requested review from a team November 7, 2023 12:38
@v1v v1v self-assigned this Nov 7, 2023
@v1v v1v enabled auto-merge (squash) November 7, 2023 13:28
@v1v
Copy link
Member Author

v1v commented Nov 8, 2023

In other words, this change will modify PRs like #1393, that won't contain the link to the commit but also the PR.

image

@v1v v1v merged commit bbca7e5 into elastic:main Nov 28, 2023
105 of 108 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants