fix(rum-core): avoid creating multiple transactions in startTransacti…

…on (#296)
elastic · Jun 18, 2019 · 70c3fb4 · 70c3fb4
1 parent 0116f68
commit 70c3fb4
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/packages/rum-core/src/performance-monitoring/transaction-service.js b/packages/rum-core/src/performance-monitoring/transaction-service.js
@@ -134,9 +134,7 @@ class TransactionService {
 
     if (!tr) {
       tr = this.createTransaction(name, type, perfOptions)
-    }
-
-    if (tr.canReuse()) {
+    } else if (tr.canReuse()) {
       /*
        * perfOptions could also have `canReuse:true` in which case we
        * allow a redefinition until there's a call that doesn't have that

diff --git a/packages/rum-core/test/performance-monitoring/transaction-service.spec.js b/packages/rum-core/test/performance-monitoring/transaction-service.spec.js
@@ -338,4 +338,10 @@ describe('TransactionService', function() {
       done()
     })
   })
+
+  it('should createTransaction once per startTransaction', function() {
+    spyOn(transactionService, 'createTransaction').and.callThrough()
+    transactionService.startTransaction('test-name', 'test-type')
+    expect(transactionService.createTransaction).toHaveBeenCalledTimes(1)
+  })
 })