Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: setup git using github user data #1405

Merged
merged 1 commit into from
Aug 1, 2023
Merged

ci: setup git using github user data #1405

merged 1 commit into from
Aug 1, 2023

Conversation

amannocci
Copy link
Contributor

What is the change being made?

  • Use github user data to setup git
  • The auto-generate github token was used

Why is the change being made?

  • We aren't able to publish a release using the auto-generate token since it can't be associated with a user.

@amannocci amannocci self-assigned this Jul 31, 2023
@amannocci amannocci requested a review from devcorpio July 31, 2023 20:40
devcorpio
devcorpio approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@devcorpio devcorpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devcorpio devcorpio merged commit e411e0c into main Aug 1, 2023
14 of 20 checks passed
@devcorpio devcorpio deleted the fix/github-token branch August 1, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devcorpio devcorpio devcorpio approved these changes

Assignees

@amannocci amannocci

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amannocci @devcorpio @apmmachine