Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump the github-actions group with 1 update #1484

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 18, 2024

Bumps the github-actions group with 1 update: hashicorp/vault-action.

Updates hashicorp/vault-action from 2.7.4 to 3.0.0

Release notes

Sourced from hashicorp/vault-action's releases.

v3.0.0

3.0.0 (February 15, 2024)

Improvements:

  • Bump node runtime from node16 to node20 GH-528

v2.8.1

2.8.1 (February 15, 2024)

Bugs:

  • Revert GH-509 which made a backwards incompatible bump of the node runtime from node16 to node20 GH-527

v2.8.0

2.8.0 (February 1, 2024)

Features:

  • Add ignoreNotFound input (default: false) to prevent the action from failing when a secret does not exist GH-518

Improvements:

  • bump jsrsasign from 10.8.6 to 11.0.0 GH-513
  • bump @​actions/core from 1.10.0 to 1.10.1 GH-489
  • bump jest-when from 3.5.2 to 3.6.0 GH-484
  • bump jest from 29.5.0 to 29.7.0 GH-490
  • bump @​vercel/ncc from 0.36.1 to 0.38.1 GH-503

v2.7.5

2.7.5 (January 30, 2024)

Improvements:

  • Bump node runtime from node16 to node20 GH-509
  • Bump got from 11.8.5 to 11.8.6 GH-492
Changelog

Sourced from hashicorp/vault-action's changelog.

3.0.0 (February 15, 2024)

Improvements:

  • Bump node runtime from node16 to node20 GH-529

2.8.1 (February 15, 2024)

Bugs:

  • Revert GH-509 which made a backwards incompatible bump of the node runtime from node16 to node20 GH-527

2.8.0 (February 1, 2024)

Features:

  • Add ignoreNotFound input (default: false) to prevent the action from failing when a secret does not exist GH-518

Improvements:

  • bump jsrsasign from 10.8.6 to 11.0.0 GH-513
  • bump @​actions/core from 1.10.0 to 1.10.1 GH-489
  • bump jest-when from 3.5.2 to 3.6.0 GH-484
  • bump jest from 29.5.0 to 29.7.0 GH-490
  • bump @​vercel/ncc from 0.36.1 to 0.38.1 GH-503

2.7.5 (January 30, 2024)

Improvements:

  • Bump node runtime from node16 to node20 GH-509
  • Bump got from 11.8.5 to 11.8.6 GH-492
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

@dependabot dependabot bot added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Feb 18, 2024
@dependabot dependabot bot requested a review from a team February 18, 2024 22:58
v1v
v1v previously approved these changes Feb 19, 2024
Bumps the github-actions group with 1 update: [hashicorp/vault-action](https://github.com/hashicorp/vault-action).


Updates `hashicorp/vault-action` from 2.7.4 to 3.0.0
- [Release notes](https://github.com/hashicorp/vault-action/releases)
- [Changelog](https://github.com/hashicorp/vault-action/blob/main/CHANGELOG.md)
- [Commits](hashicorp/vault-action@v2.7.4...v3.0.0)

---
updated-dependencies:
- dependency-name: hashicorp/vault-action
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: github-actions
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/github_actions/github-actions-bf288352b6 branch from 00612b1 to 1ef7fc3 Compare March 17, 2024 22:28
reakaleek
reakaleek previously approved these changes Mar 18, 2024
@devcorpio
Copy link
Contributor

This update breaks the saucelabs step.

Screenshot 2024-03-18 at 11 50 12

Somehow is related with the Vault update.

I cross-referenced this another PR: #1483

In the logs of that PR we can see something that we cannot see in the logs of this one:

Screenshot 2024-03-18 at 11 51 54

I'm checking what's going on

Copy link
Contributor

@devcorpio devcorpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't merge until the situation described here is "solved"

@devcorpio devcorpio dismissed stale reviews from reakaleek and v1v via a7f86c0 March 18, 2024 10:56
@devcorpio
Copy link
Contributor

devcorpio commented Mar 18, 2024

okay, this commit a7f86c0 fixed the situation. Now the "token" thingy is visible in the logs and the tests are running.

To be honest, it has been just a change out of "gut feeling", I don't understand the rationale, why was the step failing with the "older" versions? 🤔 well, at least the good news is that is not failing anymore

Copy link
Contributor

@devcorpio devcorpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devcorpio devcorpio requested review from v1v and reakaleek March 18, 2024 11:19
@devcorpio devcorpio merged commit 799d6be into main Mar 18, 2024
17 of 21 checks passed
@devcorpio devcorpio deleted the dependabot/github_actions/github-actions-bf288352b6 branch March 18, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants