-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump the github-actions group with 1 update #1484
chore: bump the github-actions group with 1 update #1484
Conversation
Bumps the github-actions group with 1 update: [hashicorp/vault-action](https://github.com/hashicorp/vault-action). Updates `hashicorp/vault-action` from 2.7.4 to 3.0.0 - [Release notes](https://github.com/hashicorp/vault-action/releases) - [Changelog](https://github.com/hashicorp/vault-action/blob/main/CHANGELOG.md) - [Commits](hashicorp/vault-action@v2.7.4...v3.0.0) --- updated-dependencies: - dependency-name: hashicorp/vault-action dependency-type: direct:production update-type: version-update:semver-major dependency-group: github-actions ... Signed-off-by: dependabot[bot] <[email protected]>
00612b1
to
1ef7fc3
Compare
This update breaks the saucelabs step. Somehow is related with the Vault update. I cross-referenced this another PR: #1483 In the logs of that PR we can see something that we cannot see in the logs of this one: I'm checking what's going on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't merge until the situation described here is "solved"
okay, this commit a7f86c0 fixed the situation. Now the "token" thingy is visible in the logs and the tests are running. To be honest, it has been just a change out of "gut feeling", I don't understand the rationale, why was the step failing with the "older" versions? 🤔 well, at least the good news is that is not failing anymore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Bumps the github-actions group with 1 update: hashicorp/vault-action.
Updates
hashicorp/vault-action
from 2.7.4 to 3.0.0Release notes
Sourced from hashicorp/vault-action's releases.
Changelog
Sourced from hashicorp/vault-action's changelog.
Commits
d1720f0
fix changelog link (#530)9262638
Prepare for v3.0.0 release (#529)9c2d817
Fix changelog link (#528)b477844
Prepare for v2.8.1 release (#527)9f522b8
Update to v2.8.0 (#519)efab57e
feature: add ignoreNotFound option (#518)d523bb0
chore(deps-dev): bump@vercel/ncc
from 0.36.1 to 0.38.1 (#503)11845b1
chore(deps-dev): bump jest from 29.5.0 to 29.7.0 (#490)7a6258b
chore(deps-dev): bump jest-when from 3.5.2 to 3.6.0 (#484)a0b66b1
chore(deps-dev): bump@actions/core
from 1.10.0 to 1.10.1 (#489)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major version
will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor version
will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>
will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>
will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>
will remove the ignore condition of the specified dependency and ignore conditions