Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add error.id to jaeger errors #272

Merged
merged 2 commits into from
May 7, 2024

Conversation

kruskall
Copy link
Member

@kruskall kruskall commented May 3, 2024

Add error.id (randomly generated) to jaeger errors.

Update tests to account for the new field but replace it with "dynamic" because it's generated randomly

This is the jaeger counterpart for otel:

if id, err := newUniqueID(); err == nil {
exceptionError.Id = id
}

Closes elastic/apm-server#12986

@kruskall kruskall requested a review from a team as a code owner May 3, 2024 15:25
@elastic-apm-tech elastic-apm-tech added the safe-to-test Changes are safe to run in the CI label May 3, 2024
@kruskall kruskall requested review from a team and removed request for a team May 3, 2024 15:26
@kruskall kruskall enabled auto-merge (squash) May 7, 2024 08:47
@kruskall kruskall merged commit e72603d into elastic:main May 7, 2024
5 checks passed
@kruskall kruskall deleted the fix/jaeger-error-id branch June 14, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe-to-test Changes are safe to run in the CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API UI failing for error events derived from traces with Jaeger agent
3 participants