-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: automate unified release by issue creation #12872
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Adrien Mannocci <[email protected]>
This pull request does not have a backport label. Could you fix it @amannocci? 🙏
NOTE: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before moving forward, can we send the design document to the rest of the team?
value: | | ||
## Unified Release Day | ||
|
||
We are releasing a new version today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this is the right sentence since it's not about a release today, but it could be a Feature Freeze
- type: input | ||
id: upstream | ||
attributes: | ||
label: Parent issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the parent issue is passed, do you think the GH PR that was created could also contain a reference to it and also a reference to the GitHub issue in this project that was created?
### Issues
Part of https://github.com/elastic/dev/issues/xxx
Closes https://github.com/elastic/apm-server/issues/xxx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are pros/cons in both cases.
In my opinion, we could keep the parent relationship between those issues and let the PR reference the project issue to avoid confusion in the upstream issue.
Signed-off-by: Adrien Mannocci <[email protected]>
Signed-off-by: Adrien Mannocci <[email protected]>
@amannocci what's the status of this ? |
What is the change being made?
Why is the change being made?