Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: automate unified release by issue creation #12872

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

amannocci
Copy link
Contributor

What is the change being made?

  • Create an issue template as entrypoint to trigger the unified release.

Why is the change being made?

  • We will implemented an upstream GitHub workflow that will create issue in each repository on Unified Release Day.
  • Issue tracking will be easy since we will only need to wait for all issues to be closed.

@amannocci amannocci self-assigned this Mar 26, 2024
@amannocci amannocci requested a review from a team as a code owner March 26, 2024 17:29
@amannocci amannocci requested a review from a team March 26, 2024 17:29
Copy link
Contributor

mergify bot commented Mar 26, 2024

This pull request does not have a backport label. Could you fix it @amannocci? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Mar 26, 2024
Copy link
Member

@v1v v1v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before moving forward, can we send the design document to the rest of the team?

.github/workflows/unified-release.yml Outdated Show resolved Hide resolved
value: |
## Unified Release Day

We are releasing a new version today.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this is the right sentence since it's not about a release today, but it could be a Feature Freeze

- type: input
id: upstream
attributes:
label: Parent issue
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the parent issue is passed, do you think the GH PR that was created could also contain a reference to it and also a reference to the GitHub issue in this project that was created?

### Issues

Part of https://github.com/elastic/dev/issues/xxx

Closes https://github.com/elastic/apm-server/issues/xxx

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are pros/cons in both cases.
In my opinion, we could keep the parent relationship between those issues and let the PR reference the project issue to avoid confusion in the upstream issue.

.github/ISSUE_TEMPLATE/unified-release.yml Outdated Show resolved Hide resolved
Signed-off-by: Adrien Mannocci <[email protected]>
Signed-off-by: Adrien Mannocci <[email protected]>
@kruskall
Copy link
Member

@amannocci what's the status of this ?

@v1v v1v added the backport-8.x Automated backport to the 8.x branch with mergify label Sep 10, 2024
@mergify mergify bot removed the backport-skip Skip notification from the automated backport with mergify label Sep 10, 2024
@amannocci
Copy link
Contributor Author

Hi @kruskall, I'm not working anymore in the same team.
@v1v should be the good contact

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants