Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce fleetctl as tool #13444

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

endorama
Copy link
Member

@endorama endorama commented Jun 19, 2024

We recently removed fleetctl in #13440 as it's no longer used in test, and was part of systemtest.

But there is still use for it as a standalone tool to aid development and manual testing, so I'm proposing this PR that moves it in tools/

This change adds a direct dependency between tools and systemtest, but the same dependency was present, indirectly, before this PR so I don't consider it a blocker.

We may want to refactor systemtest/fleettest to split the concerns, but I'm not sure it's worth the effort at this moment.

removed in elastic#13440 from systemtests
but still can be useful for development or manual testing purposes
@endorama endorama requested a review from a team as a code owner June 19, 2024 12:37
Copy link
Contributor

mergify bot commented Jun 19, 2024

This pull request does not have a backport label. Could you fix it @endorama? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Jun 19, 2024
@endorama
Copy link
Member Author

I don't think we need to backport this PR.

Copy link
Contributor

mergify bot commented Jul 12, 2024

This pull request is now in conflicts. Could you fix it @endorama? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b fleetctl-tool upstream/fleetctl-tool
git merge upstream/main
git push upstream fleetctl-tool

@v1v v1v added the backport-8.x Automated backport to the 8.x branch with mergify label Sep 10, 2024
@mergify mergify bot removed the backport-skip Skip notification from the automated backport with mergify label Sep 10, 2024
@v1v v1v added the backport-skip Skip notification from the automated backport with mergify label Sep 10, 2024
@mergify mergify bot removed the backport-skip Skip notification from the automated backport with mergify label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants