Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.17] ci(smoke-tests): set id-token when running other workflows (backport #13497) #13498

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 26, 2024

Motivation/summary

permissions need to be set explicitly when calling other workflows even if those workflows already have got the permissions set.

Fixes

[Invalid workflow file: .github/workflows/smoke-tests-schedule.yml#L27](https://github.com/elastic/apm-server/actions/runs/9672905228/workflow)
The workflow is not valid. .github/workflows/smoke-tests-schedule.yml (Line: 27, Col: 3): Error calling workflow 'elastic/apm-server/.github/workflows/smoke-tests-os.yml@4cf627cb98d0624f5206dfbfa30f88f64794c739'. The nested job 'smoke-tests-os' is requesting 'id-token: write', but is only allowed 'id-token: none'.

See https://github.com/elastic/apm-server/actions/runs/9672905228

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Related issues


This is an automatic backport of pull request #13497 done by [Mergify](https://mergify.com).

@mergify mergify bot added the backport label Jun 26, 2024
@mergify mergify bot assigned v1v Jun 26, 2024
@mergify mergify bot merged commit f4a7fa3 into 7.17 Jun 26, 2024
12 checks passed
@mergify mergify bot deleted the mergify/bp/7.17/pr-13497 branch June 26, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants