-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: clarify automation in release workflow #13851
base: main
Are you sure you want to change the base?
docs: clarify automation in release workflow #13851
Conversation
Signed-off-by: inge4pres <[email protected]>
This pull request does not have a backport label. Could you fix it @inge4pres? 🙏
NOTE: |
Signed-off-by: inge4pres <[email protected]>
@@ -72,7 +72,9 @@ For patch releases, only the version on the existing major and minor version bra | |||
|
|||
* A new [tag](https://github.com/elastic/apm-server/releases) will automatically be created on GitHub. | |||
|
|||
* Bump the version in anticipation of the next release, e.g. [after 8.13.3 release](https://github.com/elastic/apm-server/pull/13066) bump to 8.13.4. **Prepare this PR ahead of time** but only merge it once pinged by the Release Manager on release date. | |||
* Merge the PRs created by the GitHub workflow ran as part of the steps in the ["Day after feature freeze"](#day-after-feature-freeze) section. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This only applies to patch release, not minor release, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree and this needs to be clarified as there are a lot of PRs involved in this process and as we discovered recently other PRs (docs + version bumps) must not be merged before release date.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do we need to do to clarify? Reach out to the robots?
This only applies to patch release, not minor release, right?
Good point, thanks for the callout. Should we make a distinction like we do above for minor/patch release?
E.g. say: "for minor releases, merge this and that; for patch releases, merge this other and that other PR".
Co-authored-by: Carson Ip <[email protected]>
Motivation/summary
During the 8.15 release cycle we noticed some differences between what documented as needed and the available tooling for release.
This Pr is an attempt to clarify what's documented.